Serialize FFI tests that share panic state - #786
Draft
Anand Krishnamoorthi (anakrish) with Copilot wants to merge 3 commits into
Draft
Serialize FFI tests that share panic state#786Anand Krishnamoorthi (anakrish) with Copilot wants to merge 3 commits into
Anand Krishnamoorthi (anakrish) with Copilot wants to merge 3 commits into
Conversation
Copilot started work on behalf of
Anand Krishnamoorthi (anakrish)
August 14, 2026 15:05
View session
Co-authored-by: anakrish <35780660+anakrish@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix the failing GitHub Actions job test
Serialize FFI tests that share panic state
Aug 14, 2026
Copilot started reviewing on behalf of
Anand Krishnamoorthi (anakrish)
August 14, 2026 15:20
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the bindings/ffi test suite run single-threaded to avoid intermittent failures caused by tests interacting through a process-global panic/poison state during concurrent execution.
Changes:
- Pass
-- --test-threads=1tocargo testforbindings/ffito serialize its Rust test harness. - Improve isolation of the intentional poison-state test so it doesn’t contaminate unrelated FFI tests running in the same crate test run.
Suppressed comments (1)
xtask/src/tasks/bindings/ffi.rs:169
- The step label string no longer matches the actual invocation now that the test harness args include
-- --test-threads=1. This can make CI logs misleading when diagnosing failures; update the label to reflect the full command.
run_cargo_step(
&ffi_dir,
"cargo test --features contention_checks (bindings/ffi)",
test_args,
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot started work on behalf of
Anand Krishnamoorthi (anakrish)
August 18, 2026 20:25
View session
Co-authored-by: anakrish <35780660+anakrish@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
testActions job intermittently failed when an FFI alias-compilation test ran concurrently with the panic-guard test. The latter temporarily sets a process-global poison flag observed by guarded FFI calls.bindings/ffitests with a single test thread.