Ship .asc signature alongside .sig#502
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates releasego and the build-assets scanning logic to align detached PGP signature handling with upstream Go’s .asc convention while still recognizing legacy .sig artifacts.
Changes:
- Switch
releasegoURL/path generation from.sigto.ascfor signature files. - Update build-assets directory scanning and filename parsing to recognize both
.ascand.sig. - Refresh test data/golden outputs to reflect
.ascsignatures.
Show a summary per file
| File | Description |
|---|---|
cmd/releasego/main.go |
Updates default signature URL/path derivation from .sig to .asc. |
cmd/releasego/akams_test.go |
Updates in-test BuildAssets signature URLs to .asc. |
cmd/releasego/testdata/Test_createLinkPairs/release_studio/aka.golden.txt |
Updates expected aka.ms link targets to .asc. |
cmd/releasego/testdata/Test_createLinkPairs/blob/aka.golden.txt |
Updates expected aka.ms link targets to .asc. |
buildmodel/dockerversions/dockerversions.go |
Updates PGPSignatureURL documentation to .asc. |
buildmodel/buildassets/buildassets.go |
Recognizes .asc and .sig for signature files; expands filename parsing to cover both. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 6/6 changed files
- Comments generated: 2
gdams
force-pushed
the
dev/gadams/sig
branch
2 times, most recently
from
ad77507 to
32c6f55
Compare
dagood
requested changes
Jun 4, 2026
gdams
changed the title
Recognize both .sig and .asc signature files when scanning build output directories. The .sig extension remains the default for aka.ms links and release URLs; .asc is accepted alongside for compatibility with upstream Go tooling. See microsoft/go#181
dagood
requested changes
Jun 12, 2026
dagood
left a comment
dagood
left a comment
Member
There was a problem hiding this comment.
I'm not seeing how this ends up shipping both the .sig and .asc to aka.ms, or including both in the build assets JSON?
Member
Author
updated PTAL |
Add ASCSignatureURL to the Arch model and update CreateSummary to record .sig and .asc independently so both appear in the build assets JSON and both are shipped as aka.ms shortlinks.
dagood
requested changes
Jun 15, 2026
dagood
added
the
release-on-merge
dagood
approved these changes
Jul 8, 2026
dagood
added a commit
that referenced
this pull request
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ship an
.ascPGP signature file alongside the existing.sigfor every archive. The.sigremains the default/primary extension;.ascis produced in parallel for compatibility with upstream Go tooling (e.g. official Dockerfiles).See microsoft/go#181
Changes
.sigand.ascwhen scanning build output directories (prefer.sig).sigURLs for aka.ms links and release validationPGPSignatureURLdoc commentCompanion PR