Revert "Ship .asc signature alongside .sig"#522
Merged
Conversation
This reverts commit ebf0f3b.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts prior work that shipped an additional .asc signature alongside the existing .sig PGP signature for release artifacts, returning the release tooling and asset schemas to .sig-only behavior.
Changes:
- Remove generation and URL discovery of
.ascsignature artifacts inreleasegoand build assets summarization. - Remove the
ascSignatureUrlfield from thebuildmodel/dockerversionsArch JSON schema. - Update golden test fixtures and
.txtartest archives to match the.sig-only behavior.
Reviewed changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| cmd/releasego/testdata/Test_createLinkPairs/release_studio/aka.golden.txt | Updates expected AKA link pairs to no longer include .asc signature links. |
| cmd/releasego/testdata/Test_createLinkPairs/blob/aka.golden.txt | Updates expected link pairs to no longer include .asc signature links. |
| cmd/releasego/main.go | Stops appending .asc signature paths/URLs; keeps .sig only. |
| cmd/releasego/akams_test.go | Updates test inputs to remove ASCSignatureURL. |
| buildmodel/dockerversions/dockerversions.go | Removes ASCSignatureURL from the Arch struct JSON schema and associated docs. |
| buildmodel/buildassets/testdata/TestBuildResultsDirectoryInfo_GoldenCreateSummary/1.23dev-publish/result.golden.txt | Updates golden summary JSON to remove ascSignatureUrl. |
| buildmodel/buildassets/testdata/TestBuildResultsDirectoryInfo_GoldenCreateSummary/1.17-build/result.golden.txt | Updates golden summary JSON to remove ascSignatureUrl. |
| buildmodel/buildassets/testdata/1.23dev-publish/bin.txtar | Removes .asc files from the test archive inputs. |
| buildmodel/buildassets/testdata/1.23dev-missing-publish/bin.txtar | Removes .asc from the test archive inputs. |
| buildmodel/buildassets/testdata/1.17-build/bin.txtar | Removes .asc files from the test archive inputs. |
| buildmodel/buildassets/buildassets.go | Removes .asc handling in artifact scanning and parsing; uses .sig only. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
michelle-clayton-work
approved these changes
Jul 9, 2026
Member
Author
|
/azp run microsoft-go-infra |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #502