Skip to content

Switch tsconfig settings for all packages in the repo #4101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JasonVMo wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Switch tsconfig settings for all packages in the repo #4101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ceb92f
initial tsconfig.json changes
JasonVMo May 6, 2026
345b061
update tsconfig.json with new extends and rootDir option
JasonVMo May 6, 2026
8c3a0ad
fix erasable syntax and no default override errors
JasonVMo May 7, 2026
2dee818
add changesets file
JasonVMo May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 78 additions & 0 deletions .changeset/wacky-rabbits-retire.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
---
"@uifabricshared/foundation-composable": patch
"@fluentui-react-native/experimental-appearance-additions": patch
"@uifabricshared/theming-react-native": patch
"@uifabricshared/foundation-settings": patch
"@fluentui-react-native/experimental-activity-indicator": patch
"@fluentui-react-native/experimental-native-font-metrics": patch
"@uifabricshared/foundation-compose": patch
"@fluentui-react-native/experimental-native-date-picker": patch
"@uifabricshared/foundation-tokens": patch
"@fluentui-react-native/themed-stylesheet": patch
"@uifabricshared/themed-settings": patch
"@fluentui-react-native/contextual-menu": patch
"@fluentui-react-native/lint-config-rules": patch
"@uifabricshared/theme-registry": patch
"@fluentui-react-native/vibrancy-view": patch
"@fluentui-react-native/focus-trap-zone": patch
"@fluentui-react-native/notification": patch
"@uifabricshared/theming-ramp": patch
"@fluentui-react-native/experimental-menu-button": patch
"@fluentui-react-native/interactive-hooks": patch
"@fluentui-react-native/persona-coin": patch
"@fluentui-react-native/menu-button": patch
"@fluentui-react-native/radio-group": patch
"@fluentui-react-native/experimental-checkbox": patch
"@fluentui-react-native/dropdown": patch
"@fluentui-react-native/experimental-expander": patch
"@fluentui-react-native/overflow": patch
"@fluentui-react-native/composition": patch
"@fluentui-react-native/use-styling": patch
"@fluentui-react-native/android-theme": patch
"@fluentui-react-native/default-theme": patch
"@fluentui-react-native/theming-utils": patch
"@fluentui-react-native/focus-zone": patch
"@fluentui-react-native/pressable": patch
"@fluentui-react-native/separator": patch
"@fluentui-react-native/popover": patch
"@fluentui-react-native/experimental-shimmer": patch
"@fluentui-react-native/spinner": patch
"@fluentui-react-native/tooltip": patch
"@fluentui-react-native/use-tokens": patch
"@fluentui-react-native/theme-tokens": patch
"@fluentui-react-native/checkbox": patch
"@fluentui-react-native/experimental-avatar": patch
"@fluentui-react-native/drawer": patch
"@fluentui-react-native/experimental-shadow": patch
"@fluentui-react-native/framework": patch
"@fluentui-react-native/use-slots": patch
"@fluentui-react-native/apple-theme": patch
"@fluentui-react-native/theme-types": patch
"@fluentui-react-native/win32-theme": patch
"@fluentui-react-native/callout": patch
"@fluentui-react-native/divider": patch
"@fluentui-react-native/persona": patch
"@fluentui-react-native/tablist": patch
"@fluentui-react-native/use-slot": patch
"@fluentui-react-native/avatar": patch
"@fluentui-react-native/button": patch
"@fluentui-react-native/switch": patch
"@fluentui-react-native/badge": patch
"@fluentui-react-native/input": patch
"@fluentui-react-native/stack": patch
"@fluentui-react-native/chip": patch
"@fluentui-react-native/icon": patch
"@fluentui-react-native/link": patch
"@fluentui-react-native/menu": patch
"@fluentui-react-native/text": patch
"@fluentui-react-native/theme": patch
"@fluentui-react-native/framework-base": patch
"@fluentui/react-native": patch
"@fluentui-react-native/adapters": patch
"@fluentui-react-native/styling-utils": patch
"@fluentui-react-native/tokens": patch
"@fluentui-react-native/tester": patch
"@fluentui-react-native/codemods": patch
---

Switch tsconfig settings to more modern settings
2 changes: 1 addition & 1 deletion .yarnrc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ catalog:
"@rnx-kit/reporter": ^0.1.0
"@rnx-kit/tools-packages": ^0.1.2
"@rnx-kit/tools-typescript": ^0.1.3
"@rnx-kit/tsconfig": ^3.0.0
"@rnx-kit/tsconfig": ^3.0.3
"@rnx-kit/types-kit-config": "^1.0.0"
"@rnx-kit/types-node": "^1.0.0"
"@types/jasmine": 5.1.13
Expand Down
2 changes: 1 addition & 1 deletion apps/E2E/src/ActivityIndicator/pages/ActivityIndicatorPageObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class ActivityIndicatorPageObject extends BasePage {
return ACTIVITY_INDICATOR_TESTPAGE;
}

get _primaryComponentName() {
override get _primaryComponentName() {
return ACTIVITY_INDICATOR_TEST_COMPONENT;
}

Expand Down
4 changes: 2 additions & 2 deletions apps/E2E/src/Avatar/pages/AvatarPageObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ class AvatarPageObject extends BasePage {
return AVATAR_TESTPAGE;
}

get _primaryComponentName() {
override get _primaryComponentName() {
return AVATAR_TEST_COMPONENT;
}

get _secondaryComponentName() {
override get _secondaryComponentName() {
return AVATAR_SECONDARY_TEST_COMPONENT;
}
}
Expand Down
4 changes: 2 additions & 2 deletions apps/E2E/src/Badge/pages/BasicBadgePageObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ class BasicBadgePageObject extends BasePage {
return BADGE_TESTPAGE;
}

get _primaryComponentName() {
override get _primaryComponentName() {
return BADGE_TEST_COMPONENT;
}

get _secondaryComponentName() {
override get _secondaryComponentName() {
return BADGE_SECONDARY_TEST_COMPONENT;
}
}
Expand Down
4 changes: 2 additions & 2 deletions apps/E2E/src/ButtonLegacy/pages/ButtonLegacyPageObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@ class ButtonLegacyPageObject extends BasePage {
return BUTTON_TESTPAGE;
}

get _primaryComponentName() {
override get _primaryComponentName() {
return BUTTON_TEST_COMPONENT_DEPRECATED;
}

get _secondaryComponentName() {
override get _secondaryComponentName() {
return BUTTON_NO_A11Y_LABEL_COMPONENT_DEPRECATED;
}

Expand Down
4 changes: 2 additions & 2 deletions apps/E2E/src/ButtonV1/pages/ButtonV1PageObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@ class ButtonV1PageObject extends BasePage {
return BUTTON_TESTPAGE;
}

get _primaryComponentName() {
override get _primaryComponentName() {
return BUTTON_TEST_COMPONENT;
}

get _secondaryComponentName() {
override get _secondaryComponentName() {
return BUTTON_NO_A11Y_LABEL_COMPONENT;
}

Expand Down
2 changes: 1 addition & 1 deletion apps/E2E/src/Callout/pages/CalloutPageObject.win.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class CalloutPageObject extends BasePage {
return CALLOUT_TESTPAGE;
}

get _primaryComponentName() {
override get _primaryComponentName() {
return CALLOUT_TEST_COMPONENT;
}

Expand Down
4 changes: 2 additions & 2 deletions apps/E2E/src/CheckboxLegacy/pages/CheckboxLegacyPageObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,11 @@ class CheckboxLegacyPageObject extends BasePage {
return CHECKBOX_TESTPAGE;
}

get _primaryComponentName() {
override get _primaryComponentName() {
return CHECKBOX_TEST_COMPONENT;
}

get _secondaryComponentName() {
override get _secondaryComponentName() {
return CHECKBOX_NO_A11Y_LABEL_COMPONENT;
}

Expand Down
4 changes: 2 additions & 2 deletions apps/E2E/src/CheckboxV1/pages/CheckboxV1PageObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,11 @@ class CheckboxV1PageObject extends BasePage {
return CHECKBOXV1_TESTPAGE;
}

get _primaryComponentName() {
override get _primaryComponentName() {
return CHECKBOXV1_TEST_COMPONENT;
}

get _secondaryComponentName() {
override get _secondaryComponentName() {
return CHECKBOXV1_NO_A11Y_LABEL_COMPONENT;
}

Expand Down
2 changes: 1 addition & 1 deletion apps/E2E/src/Chip/pages/ChipPageObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class ChipPageObject extends BasePage {
return CHIP_TESTPAGE;
}

get _primaryComponentName() {
override get _primaryComponentName() {
return CHIP_TEST_COMPONENT;
}

Expand Down
2 changes: 1 addition & 1 deletion apps/E2E/src/Drawer/pages/DrawerPageObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class DrawerPageObject extends BasePage {
return Drawer_TESTPAGE;
}

get _primaryComponentName() {
override get _primaryComponentName() {
return Drawer_TEST_COMPONENT;
}

Expand Down
2 changes: 1 addition & 1 deletion apps/E2E/src/FocusTrapZone/pages/FocusTrapZonePageObject.win.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class FocusTrapZonePageObject extends BasePage {
return FOCUSTRAPZONE_TESTPAGE;
}

get _primaryComponentName() {
override get _primaryComponentName() {
return FOCUSTRAPZONE_TEST_COMPONENT;
}

Expand Down
2 changes: 1 addition & 1 deletion apps/E2E/src/FocusZone/pages/FocusZonePageObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ class FocusZonePageObject extends BasePage {
return FOCUSZONE_TESTPAGE;
}

get _primaryComponentName() {
override get _primaryComponentName() {
return FOCUSZONE_TEST_COMPONENT;
}

Expand Down
4 changes: 2 additions & 2 deletions apps/E2E/src/IconLegacy/pages/IconLegacyPageObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ class IconLegacyPageObject extends BasePage {
return ICON_TESTPAGE;
}

get _primaryComponentName() {
override get _primaryComponentName() {
return ICON_TEST_COMPONENT;
}

get _secondaryComponentName() {
override get _secondaryComponentName() {
return ICON_NO_A11Y_LABEL_COMPONENT;
}

Expand Down
4 changes: 2 additions & 2 deletions apps/E2E/src/IconV1/pages/IconV1PageObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ class IconV1PageObject extends BasePage {
return ICON_TESTPAGE;
}

get _primaryComponentName() {
override get _primaryComponentName() {
return ICON_TEST_COMPONENT;
}

get _secondaryComponentName() {
override get _secondaryComponentName() {
return ICON_FONT_TEST_COMPONENT;
}

Expand Down
2 changes: 1 addition & 1 deletion apps/E2E/src/Input/pages/InputPageObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class InputPageObject extends BasePage {
return INPUT_TESTPAGE;
}

get _primaryComponentName() {
override get _primaryComponentName() {
return INPUT_TEST_COMPONENT;
}

Expand Down
4 changes: 2 additions & 2 deletions apps/E2E/src/LinkLegacy/pages/LinkLegacyPageObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ class LinkLegacyPageObject extends BasePage {
return LINK_TESTPAGE;
}

get _primaryComponentName() {
override get _primaryComponentName() {
return LINK_TEST_COMPONENT;
}

get _secondaryComponentName() {
override get _secondaryComponentName() {
return LINK_NO_A11Y_LABEL_COMPONENT;
}

Expand Down
4 changes: 2 additions & 2 deletions apps/E2E/src/LinkV1/pages/LinkV1PageObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@ class LinkV1PageObject extends BasePage {
return LINKV1_TESTPAGE;
}

get _primaryComponentName() {
override get _primaryComponentName() {
return LINKV1_TEST_COMPONENT;
}

get _secondaryComponentName() {
override get _secondaryComponentName() {
return LINKV1_NO_A11Y_LABEL_COMPONENT;
}

Expand Down
2 changes: 1 addition & 1 deletion apps/E2E/src/Overflow/pages/OverflowPageObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ class OverflowPageObject extends BasePage {
return OVERFLOW_TESTPAGE;
}

get _primaryComponentName() {
override get _primaryComponentName() {
return OVERFLOW_TEST_COMPONENT;
}
}
Expand Down
2 changes: 1 addition & 1 deletion apps/E2E/src/Persona/pages/PersonaPageObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class PersonaPageObject extends BasePage {
return PERSONA_TESTPAGE;
}

get _primaryComponentName() {
override get _primaryComponentName() {
return PERSONA_TEST_COMPONENT;
}

Expand Down
2 changes: 1 addition & 1 deletion apps/E2E/src/PersonaCoin/pages/PersonaCoinPageObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class PersonaCoinPageObject extends BasePage {
return PERSONACOIN_TESTPAGE;
}

get _primaryComponentName() {
override get _primaryComponentName() {
return PERSONACOIN_TEST_COMPONENT;
}

Expand Down
2 changes: 1 addition & 1 deletion apps/E2E/src/Pressable/pages/PressablePageObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class PressablePageObject extends BasePage {
return PRESSABLE_TESTPAGE;
}

get _primaryComponentName() {
override get _primaryComponentName() {
return PRESSABLE_TEST_COMPONENT;
}

Expand Down
4 changes: 2 additions & 2 deletions apps/E2E/src/RadioGroupV1/pages/RadioGroupV1PageObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,11 @@ class RadioGroupV1Page extends BasePage {
return RADIOGROUPV1_TESTPAGE;
}

get _primaryComponentName() {
override get _primaryComponentName() {
return RADIOGROUPV1_TEST_COMPONENT;
}

get _secondaryComponentName() {
override get _secondaryComponentName() {
return RADIOGROUPV1_NO_A11Y_LABEL_COMPONENT;
}

Expand Down
2 changes: 1 addition & 1 deletion apps/E2E/src/Separator/pages/SeparatorPageObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class SeparatorPageObject extends BasePage {
return SEPARATOR_TESTPAGE;
}

get _primaryComponentName() {
override get _primaryComponentName() {
return SEPARATOR_TEST_COMPONENT;
}

Expand Down
2 changes: 1 addition & 1 deletion apps/E2E/src/Shimmer/pages/ShimmerPageObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class ShimmerPageObject extends BasePage {
return SHIMMER_TESTPAGE;
}

get _primaryComponentName() {
override get _primaryComponentName() {
return SHIMMER_TEST_COMPONENT;
}

Expand Down
2 changes: 1 addition & 1 deletion apps/E2E/src/Spinner/pages/SpinnerPageObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class SpinnerPageObject extends BasePage {
return SPINNER_TESTPAGE;
}

get _primaryComponentName() {
override get _primaryComponentName() {
return SPINNER_TEST_COMPONENT;
}

Expand Down
2 changes: 1 addition & 1 deletion apps/E2E/src/Svg/pages/SvgPageObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class SvgPageObject extends BasePage {
return SVG_TESTPAGE;
}

get _primaryComponentName() {
override get _primaryComponentName() {
return SVG_TEST_COMPONENT;
}

Expand Down
4 changes: 2 additions & 2 deletions apps/E2E/src/Switch/pages/SwitchPageObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,11 @@ class SwitchPageObject extends BasePage {
return SWITCH_TESTPAGE;
}

get _primaryComponentName() {
override get _primaryComponentName() {
return SWITCH_TEST_COMPONENT;
}

get _secondaryComponentName() {
override get _secondaryComponentName() {
return SWITCH_NO_A11Y_LABEL_COMPONENT;
}

Expand Down
2 changes: 1 addition & 1 deletion apps/E2E/src/TabList/pages/TabListPageObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ class TabListPageObject extends BasePage {
return HOMEPAGE_TABLIST_BUTTON;
}

get _primaryComponentName() {
override get _primaryComponentName() {
return TABLIST_TEST_COMPONENT;
}
}
Expand Down
Loading
Loading