Switch tsconfig settings for all packages in the repo#4101
Open
Switch tsconfig settings for all packages in the repo#4101
Conversation
Saadnajmi
reviewed
May 7, 2026
| import { FluentTesterApp } from '@fluentui-react-native/tester-core'; | ||
| AppRegistry.registerComponent('FluentTester', () => FluentTesterApp); | ||
| export default FluentTesterApp; | ||
| //# sourceMappingURL=index.js.map No newline at end of file |
Saadnajmi
approved these changes
May 7, 2026
| const tester_core_1 = require("@fluentui-react-native/tester-core"); | ||
| react_native_1.AppRegistry.registerComponent('FluentTester', () => tester_core_1.FluentTesterApp); | ||
| exports.default = tester_core_1.FluentTesterApp; | ||
| //# sourceMappingURL=index.js.map No newline at end of file |
Comment on lines
-70
to
+75
| export enum AndroidMenuStates { | ||
| Hidden, | ||
| Animating, | ||
| Shown, | ||
| } | ||
| export const AndroidMenuStates = { | ||
| Hidden: 0, | ||
| Animating: 1, | ||
| Shown: 2, | ||
| } as const; | ||
| export type AndroidMenuStates = (typeof AndroidMenuStates)[keyof typeof AndroidMenuStates]; |
Collaborator
There was a problem hiding this comment.
Probably out of scope for this PR, but all of these would be better served as string unions right?
| "compilerOptions": { | ||
| "outDir": "lib", | ||
| "lib": ["es2022", "dom"] | ||
| "lib": ["es2022", "dom"], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
-- all
Description of changes
This change has two parts, the config level and package level.
At the config level:
erasableSyntaxOnlyandnoDefaultOverridesto the looser configAt the package level:
For packages the type errors fixed fall into several buckets: