Skip to content

Handle empty test failure stack traces #2259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kiwigitops wants to merge 1 commit into from
+39 −11
Closed

Handle empty test failure stack traces #2259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Actions/AnalyzeTests/TestResultAnalyzer.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,11 @@ function GetTestResultSummaryMD {
foreach($failure in $testcase.ChildNodes) {
Write-Host " - Error: $($failure.message)"
Write-Host " Stacktrace:"
Write-Host " $($failure."#text".Trim().Replace("`n","`n "))"
$stackTrace = $failure.InnerText.Trim()
Write-Host " $($stackTrace.Replace("`n","`n "))"
$testFailureNode = [FailureNode]::new($true)
$testFailureNode.errorMessage = $failure.message
$testFailureNode.errorStackTrace = $($failure."#text".Trim().Replace("`n","<br/>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;"))
$testFailureNode.errorStackTrace = $($stackTrace.Replace("`n","<br/>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;"))
$testCaseFailureNode.childSummaries.Add($testFailureNode) | Out-Null
}
$suiteFailureNode.childSummaries.Add($testCaseFailureNode) | Out-Null
Expand Down
45 changes: 36 additions & 9 deletions Tests/AnalyzeTests.Test.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,15 +135,42 @@ Describe "AnalyzeTests Action Tests" {
$script:warningCount | Should -be 0
}

It 'Test GetPageScriptingTestResultSummaryMD returns a hashtable' {
. (Join-Path $scriptRoot 'TestResultAnalyzer.ps1')
$output = GetPageScriptingTestResultSummaryMD -testResultsFile (Join-Path $PSScriptRoot 'TestArtifacts/PageScriptingTestResults.xml') -project 'TestProject'
$output | Should -BeOfType 'hashtable'
}

AfterAll {
Remove-Item -Path $bcptFilename -Force -ErrorAction SilentlyContinue
Remove-Item -Path $bcptBaseLine1 -Force -ErrorAction SilentlyContinue
It 'Test GetPageScriptingTestResultSummaryMD returns a hashtable' {
. (Join-Path $scriptRoot 'TestResultAnalyzer.ps1')
$output = GetPageScriptingTestResultSummaryMD -testResultsFile (Join-Path $PSScriptRoot 'TestArtifacts/PageScriptingTestResults.xml') -project 'TestProject'
$output | Should -BeOfType 'hashtable'
}

It 'Test GetTestResultSummaryMD handles empty failure stack traces' {
. (Join-Path $scriptRoot '../AL-Go-Helper.ps1')
. (Join-Path $scriptRoot 'TestResultAnalyzer.ps1')

$testResultsFile = Join-Path ([System.IO.Path]::GetTempPath()) "$([GUID]::NewGuid().ToString()).xml"
try {
@'
<?xml version="1.0" encoding="utf-8"?>
<testsuites>
<testsuite name="Suite" tests="1" failures="1" skipped="0" time="1.0">
<properties>
<property name="appName" value="App" />
</properties>
<testcase name="Case" time="1.0">
<failure message="boom"></failure>
</testcase>
</testsuite>
</testsuites>
'@ | Set-Content -Path $testResultsFile -Encoding UTF8

{ GetTestResultSummaryMD -testResultsFile $testResultsFile } | Should -Not -Throw
}
finally {
Remove-Item -Path $testResultsFile -Force -ErrorAction SilentlyContinue
}
}

AfterAll {
Remove-Item -Path $bcptFilename -Force -ErrorAction SilentlyContinue
Remove-Item -Path $bcptBaseLine1 -Force -ErrorAction SilentlyContinue
Remove-Item -Path $bcptBaseLine2 -Force -ErrorAction SilentlyContinue
}
}
Loading