Handle empty test failure stack traces#2259
Closed
kiwigitops wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the AnalyzeTests “normal” test result summarization to tolerate <failure> elements with no stack trace content (empty XML nodes), preventing runtime errors during markdown/HTML failure summary generation.
Changes:
- Switch stack trace extraction from
."#text"to.InnerTextand reuse a normalized$stackTracevalue for both log output and failure summary nodes. - Add a Pester regression test that writes a minimal
TestResults.xmlcontaining an empty<failure>node and assertsGetTestResultSummaryMDdoes not throw.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Actions/AnalyzeTests/TestResultAnalyzer.ps1 | Uses .InnerText to reliably read empty failure nodes as "" (not $null) and preserves existing formatting behavior for non-empty traces. |
| Tests/AnalyzeTests.Test.ps1 | Adds regression coverage for empty <failure> stack traces by asserting GetTestResultSummaryMD runs without exceptions. |
Collaborator
|
Issue already being handled in #2257 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InnerTextwhen reading failure stack traces so empty XML failure nodes produce an empty string instead of$null<failure>nodeCloses #2256.
Testing
git diff --checkInvoke-Pester -Path .\Tests\AnalyzeTests.Test.ps1could not run locally because the installed Windows PowerShell Pester module is 3.4.0 and does not provide the repo helper'sAdd-AssertionOperatorcommand.