Skip to content

fix(runtime): synchronize concurrent terminal state - #589

Merged
matdev83 merged 1 commit into
mainfrom
fix/pre-oss-runtime-races
Sep 4, 2026
Merged

fix(runtime): synchronize concurrent terminal state#589
matdev83 merged 1 commit into
mainfrom
fix/pre-oss-runtime-races

Conversation

@matdev83

@matdev83 matdev83 commented Sep 4, 2026

Copy link
Copy Markdown
Owner

Changes

  • serialize attempt accounting mutation and snapshots during concurrent Recv/Close/terminal settlement
  • detach tool/prompt sideband references safely without mutating a Recv-owned assembler
  • freeze terminal decision provider identity under the existing decision lock
  • publish test attempt slots only after helper inheritance is complete
  • reset the core line budget to measured race-safe size plus 25 lines

Evidence

  • classified all 32 race warnings from exact Linux run 33844396281 into accounting teardown, sideband teardown, provider identity, and test helper publication roots
  • focused concurrent terminal tests pass 10x
  • full internal/core/runtime suite passes
  • exact scoped packages pass without race locally (Windows race unavailable)
  • internal/archtest passes

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: fd99cbdd-8205-42e7-99f8-48bdeeb31100


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant