Skip to content

fix(pre-oss): hermetic git identity in inventory SHA test - #586

Merged
matdev83 merged 1 commit into
mainfrom
fix/speccheck-git-identity
Sep 3, 2026
Merged

fix(pre-oss): hermetic git identity in inventory SHA test#586
matdev83 merged 1 commit into
mainfrom
fix/speccheck-git-identity

Conversation

@matdev83

@matdev83 matdev83 commented Sep 3, 2026

Copy link
Copy Markdown
Owner

Main-CI red: TestResidualOwnershipInventoryContract_ValidatesSHAIdentity/ImplementationSHAMismatch failed with commit-tree exit 128 on a bare worker (no git user.name/user.email configured). The test shelled commit-tree in the real repo relying on ambient identity.

Fix: explicit -c user.name/user.email/commit.gpgsign=false on that invocation (repo config untouched; temp-repo DivergedBaseline test was already hermetic). 1 Go file (test only).

Evidence: targeted subtests + full speccheck package green; commit-tree with explicit identity verified.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 14f5deac-cb3d-407a-89f1-78de1b85e2f2


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant