Enable lints for all packages. - #57
Merged
Merged
Conversation
xStrom
marked this pull request as ready for review
April 18, 2026 09:42
DJMcNab
approved these changes
Apr 18, 2026
Member
There was a problem hiding this comment.
Hmm, what was the clippy error here?
Member
Author
There was a problem hiding this comment.
Loss of data by truncating to u32, but the two local methods could just as well operate on usize without conversion. In practice even u16 would probably be enough. I went with usize because that's what the source data is already in and it matches the machine word size.
Comment on lines
+16
to
+19
| #[expect( | ||
| missing_debug_implementations, | ||
| reason = "actions don't implement Debug" | ||
| )] |
Member
There was a problem hiding this comment.
A Debug super trait would also be reasonable to try here.
Member
Author
There was a problem hiding this comment.
Good idea, switched it to a super trait.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lints are now enabled for all packages. The code changes satisfy Clippy.