Rename packages to use underscores. - #58
Merged
Merged
Conversation
xStrom
marked this pull request as ready for review
April 18, 2026 13:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest Linebender standard is to name packages with an underscore instead of a dash. Historically we used dashes, but later migrated to underscores. One of the main motivators being that then the package name matches how it is imported in code (always underscore).
This wasn't well documented on the Linebender website, which I just recently fixed. Also, just taking a peek at the Vello or Xilem repos will show packages like
vello_hybridandxilem_masonry.Because packages can't be renamed after publishing (
pkg_nameandpkg-nameare considered identical by crates.io) it's important to get this renaming done before we publish.In addition to changing the dashes to underscores, I also changed the
kompari_clioutput binary name to justkomparias that seems far nicer to me than eitherkompari-cliorkompari_cli. Also, this binary name can be easily changed later if we want to.