Skip to content

fix: bound Obsidian CLI capability probes (#250) - #252

Draft
levineam wants to merge 8 commits into
mainfrom
codex/GH-250-obsidian-probe-timeout
Draft

fix: bound Obsidian CLI capability probes (#250)#252
levineam wants to merge 8 commits into
mainfrom
codex/GH-250-obsidian-probe-timeout

Conversation

@levineam

Copy link
Copy Markdown
Owner

Summary

  • run Obsidian capability probes in an owned worker and process group
  • contain timed-out descendants through TERM/KILL escalation without touching unrelated processes
  • preserve indeterminate/busy timeout classification and bound captured output by bytes
  • gate the regression in the root test suite, including POSIX descendant and Windows containment seams

Verification

  • focused adapter suite: 27/27 passed
  • full dependency-provisioned npm test: passed
  • independent Terra review: no P0-P2 findings
  • package dry run includes the worker

Safety

No real Obsidian process or vault was invoked or written. The regressions use temporary fake CLI fixtures only.

Closes #250

@levineam

levineam commented Sep 1, 2026

Copy link
Copy Markdown
Owner Author

HOLD — final independent review found an identity-unsafe cached-PID kill path and capture/polling regressions at exact head fc9a7f2. Do not merge. The portable process-group approach cannot guarantee arbitrary detached-descendant containment without risking unrelated processes; redesign under a separate bounded contract. See #250 and #260.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bound the Obsidian CLI probe when the app is stopped

1 participant