Skip to content

secure: harden Hermes setup workspace permissions #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
levineam wants to merge 1 commit into
base: main
Choose a base branch
from
Open

secure: harden Hermes setup workspace permissions #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions runtimes/hermes/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

set -e

# Workspace files contain personal context. Keep everything created by this
# script private even when the caller has a permissive default umask.
umask 077

SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
REPO_ROOT="$(cd "$SCRIPT_DIR/../.." && pwd)"
CORE_DIR="$REPO_ROOT/core"
Expand All @@ -13,7 +17,12 @@ GOV_DIR="$REPO_ROOT/core/governance"

# Default workspace is this clone root, override with first argument
WORKSPACE_INPUT="${1:-$REPO_ROOT}"
if [ -L "$WORKSPACE_INPUT" ]; then
echo "Refusing to use a symlink as the jarvOS workspace: $WORKSPACE_INPUT" >&2
exit 1
fi
mkdir -p "$WORKSPACE_INPUT"
chmod 700 "$WORKSPACE_INPUT"
WORKSPACE="$(cd "$WORKSPACE_INPUT" && pwd)"
# The Hermes CLI honors HERMES_HOME. Keeping the setup script on the same
# boundary makes disposable parity rehearsals safe and avoids touching the
Expand Down Expand Up @@ -138,6 +147,15 @@ echo ""

mkdir -p "$WORKSPACE/pms" "$WORKSPACE/governance"

# Never follow an existing link when installing files that can hold private
# user context (or the behavioral files loaded alongside that context).
for workspace_file in AGENTS.md SOUL.md IDENTITY.md USER.md MEMORY.md ONTOLOGY.md TOOLS.md; do
if [ -L "$WORKSPACE/$workspace_file" ]; then
echo "Refusing to write through workspace symlink: $WORKSPACE/$workspace_file" >&2
exit 1
fi
done

copy_if_missing() {
local src="$1"
local dst="$2"
Expand Down Expand Up @@ -295,6 +313,13 @@ EOF
fi
fi

# Harden both newly created files and files retained from an earlier setup.
for private_file in AGENTS.md SOUL.md IDENTITY.md USER.md MEMORY.md ONTOLOGY.md TOOLS.md; do
if [ -f "$WORKSPACE/$private_file" ]; then
chmod 600 "$WORKSPACE/$private_file"
fi
done

# ── Shared secondbrain vault onboarding ──
echo "→ Detecting shared secondbrain vault..."
DETECT_VAULT="$REPO_ROOT/modules/jarvos-secondbrain/scripts/detect-vault.js"
Expand Down
Loading