secure: harden Hermes setup workspace permissions - #193
Open
levineam wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
USER.md,MEMORY.md,ONTOLOGY.md) can contain sensitive personal data and must be owner-only by default.Description
umask 077at the top ofruntimes/hermes/setup.sh.WORKSPACE_INPUTis a symlink.chmod 700on the workspace path aftermkdir -p.chmod 600toAGENTS.md,SOUL.md,IDENTITY.md,USER.md,MEMORY.md,ONTOLOGY.md, andTOOLS.mdat the end of setup.Testing
bash -n runtimes/hermes/setup.sh, which succeeded.node --test runtimes/hermes/test/artifact-generation.test.js, which passed.umask 022and confirmed the workspace directory is0700and the listed sensitive files are0600.Refusing to use a symlinkas expected.Codex Task