Skip to content

Fix frontmatter parsing to preserve YAML privacy tags #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
levineam wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix frontmatter parsing to preserve YAML privacy tags #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions modules/jarvos-secondbrain/packages/jarvos-secondbrain-notes/src/lib/note-schema.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ function parseScalarValue(raw) {
const items = [];
for (const line of String(raw).split('\n')) {
const m = line.match(/^\s*-\s+(.*)$/);
if (m) items.push(m[1].trim());
if (m) items.push(stripQuotes(m[1]));
}
if (items.length) return items;
}
Expand Down Expand Up @@ -306,7 +306,12 @@ function parseScalarValue(raw) {
try {
return JSON.parse(trimmed);
} catch (_) {
// Fall through.
// YAML flow sequences do not require JSON-style quoted strings.
if (trimmed.startsWith('[') && trimmed.endsWith(']')) {
const contents = trimmed.slice(1, -1).trim();
if (!contents) return [];
return contents.split(',').map((item) => stripQuotes(item));
}
}
}
return stripQuotes(trimmed);
Expand Down
35 changes: 35 additions & 0 deletions modules/jarvos-secondbrain/tests/manual-notes-maintenance.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,41 @@ test('manual notes apply keeps sensitive artifacts local and clears automatic qu
assert.equal(summary.gates.sensitiveNotesExcludedFromAutomaticQueues, true);
});

test('manual notes apply recognizes private tags in standard YAML lists', () => {
const { notesDir, knowledgeDir, statePath } = fixture();
const variants = {
'Block Tags.md': 'tags:\n - private',
'Quoted Block Tags.md': 'tags:\n - "sensitive"',
'Flow Tags.md': 'tags: [private, reference]',
};

for (const [name, tags] of Object.entries(variants)) {
writeNote(notesDir, name, [
'---',
'status: active',
'type: reference',
'project: ""',
'created: 2026-06-22',
'updated: 2026-06-22',
'author: andrew',
tags,
'---',
'',
`# ${name.replace(/\.md$/, '')}`,
'',
'This note must remain out of automatic queues.',
].join('\n'));
}

const report = processOnce(flagsFor({ notesDir, knowledgeDir, statePath, apply: true }), applyOptions());

assert.equal(report.optimization.sensitiveSkipped, 3);
assert.equal(report.optimization.gbrainQueued, 0);
assert.equal(report.optimization.memoryWikiQueued, 0);
assert.deepEqual(readJson(path.join(knowledgeDir, 'gbrain-import-queue.json')).entries, {});
assert.deepEqual(readJson(path.join(knowledgeDir, 'memory-wiki-queue.json')).entries, {});
});

test('manual notes apply parks unfixable frontmatter without optimizer side effects', () => {
const { notesDir, knowledgeDir, statePath } = fixture();
const original = [
Expand Down
Loading