Fix frontmatter parsing to preserve YAML privacy tags - #184
Open
levineam wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
tags:\n - privateand unquoted flow lists liketags: [private]to be mis-parsed and allowed private/sensitive notes to be queued.Description
parseScalarValueinmodules/jarvos-secondbrain/packages/jarvos-secondbrain-notes/src/lib/note-schema.jsto collect multiline YAML list items and callstripQuoteson each item.tags: [private, reference]) are split andstripQuotes-normalized whenJSON.parsefails.manual notes apply recognizes private tags in standard YAML listsinmodules/jarvos-secondbrain/tests/manual-notes-maintenance.test.jscovering block, quoted block, and flow variants and adjust assertions to validate that the automatic queues contain emptyentriesfor private notes.Testing
node --test modules/jarvos-secondbrain/tests/manual-notes-maintenance.test.jsand all tests passed (13/13).report.optimization.sensitiveSkippedincreased for the private-tag variants and thatgbrain-import-queue.jsonandmemory-wiki-queue.jsonhave emptyentriesas expected.Codex Task