Skip to content

add boulder-mtca service#8776

Merged
jsha merged 4 commits into
mainfrom
boulder-mtca2
Jun 5, 2026
Merged

add boulder-mtca service#8776
jsha merged 4 commits into
mainfrom
boulder-mtca2

Conversation

@jsha
Copy link
Copy Markdown
Contributor

@jsha jsha commented Jun 3, 2026

Includes a proto file with a service definition, an entry in startservers.py and consul.hcl, and configs in test/config and test/config-next (since startservers doesn't currently have a nice way for services to start only in config-next, particularly once boulder-ra starts depending on boulder-mtca in CI).

Also, fix a problem from #8764: the newly added field in orders was mtcaID but should have been mtcLogID.

@jsha
Copy link
Copy Markdown
Contributor Author

jsha commented Jun 3, 2026

Same issue as #8775: govulncheck is failing on Go stdlib functions because actions/setup-go doesn't know about the latest Go release. Evidently it checks https://github.com/actions/go-versions/blob/main/versions-manifest.json.

@jsha jsha marked this pull request as ready for review June 3, 2026 05:26
@jsha jsha requested a review from a team as a code owner June 3, 2026 05:26
@jsha jsha requested a review from aarongable June 3, 2026 05:26
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2026

@jsha, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values.

aarongable
aarongable previously approved these changes Jun 3, 2026
Copy link
Copy Markdown
Contributor

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some proto nits

Comment thread mtca/proto/mtca.proto
package mtca;
option go_package = "github.com/letsencrypt/boulder/mtca/proto";

// MTCA issues MTC certificates.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"ATM machine"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the future to which we are doomed. MT certificates feels wrong; "issues MTCs" is also ugly IMO. I think the path is to just make peace with saying ATM machine for the rest of our lives.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, "issues MTCs" doesn't sound bad to me personally. I'd also be fine with it just saying "issues Merkle Tree Certificates", given that this is sorta the entry-point into documentation for this package.

But also none of this matters, the point of language is to communicate and the current version is clear.

Comment thread mtca/proto/mtca.proto Outdated
Comment thread mtca/proto/mtca.proto Outdated
Comment thread mtca/proto/mtca.proto
aarongable
aarongable previously approved these changes Jun 3, 2026
@jsha
Copy link
Copy Markdown
Contributor Author

jsha commented Jun 3, 2026

One more proto update:

  • not using checkpointSubtreeID yet, remove it
  • Since we have mtcLogID in the response, mtcSerialNumber is somewhat redundant. Serial numbers contain log number as a prefix, and log IDs contain log number as a suffix. Use mtcEntryIndex instead.

@aarongable aarongable requested review from a team and beautifulentropy and removed request for a team June 3, 2026 23:41
@jsha jsha force-pushed the boulder-mtca2 branch from 01e5525 to 941778f Compare June 4, 2026 20:42
@jsha
Copy link
Copy Markdown
Contributor Author

jsha commented Jun 4, 2026

Rebased on main after the digitalSignature change landed, and added one commit to tidy up some copy-pasted startup-order dependencies in startservers.py.

@jsha jsha merged commit e4f4650 into main Jun 5, 2026
19 checks passed
@jsha jsha deleted the boulder-mtca2 branch June 5, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants