add boulder-mtca service#8776
Conversation
|
Same issue as #8775: govulncheck is failing on Go stdlib functions because actions/setup-go doesn't know about the latest Go release. Evidently it checks https://github.com/actions/go-versions/blob/main/versions-manifest.json. |
|
@jsha, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
aarongable
left a comment
There was a problem hiding this comment.
LGTM with some proto nits
| package mtca; | ||
| option go_package = "github.com/letsencrypt/boulder/mtca/proto"; | ||
|
|
||
| // MTCA issues MTC certificates. |
There was a problem hiding this comment.
this is the future to which we are doomed. MT certificates feels wrong; "issues MTCs" is also ugly IMO. I think the path is to just make peace with saying ATM machine for the rest of our lives.
There was a problem hiding this comment.
Yeah, "issues MTCs" doesn't sound bad to me personally. I'd also be fine with it just saying "issues Merkle Tree Certificates", given that this is sorta the entry-point into documentation for this package.
But also none of this matters, the point of language is to communicate and the current version is clear.
|
One more proto update:
|
|
Rebased on main after the digitalSignature change landed, and added one commit to tidy up some copy-pasted startup-order dependencies in startservers.py. |
Includes a proto file with a service definition, an entry in startservers.py and consul.hcl, and configs in test/config and test/config-next (since startservers doesn't currently have a nice way for services to start only in config-next, particularly once boulder-ra starts depending on boulder-mtca in CI).
Also, fix a problem from #8764: the newly added field in
orderswasmtcaIDbut should have beenmtcLogID.