Skip to content

ra: call MTCA when profile indicates MTC#8781

Open
jsha wants to merge 5 commits into
mainfrom
boulder-mtca-ra
Open

ra: call MTCA when profile indicates MTC#8781
jsha wants to merge 5 commits into
mainfrom
boulder-mtca-ra

Conversation

@jsha
Copy link
Copy Markdown
Contributor

@jsha jsha commented Jun 4, 2026

Since we're going to be using profiles to decide whether an issuance uses MTC, remove the isMTC field from the orders table in boulder_sa_next.

Note: this is built on top of #8776. Do not merge before that PR is merged.

jsha added 5 commits June 4, 2026 13:42
Since we're going to be using profiles to decide whether an issuance uses MTC,
remove the isMTC field from the orders table in boulder_sa_next.
@jsha jsha marked this pull request as ready for review June 5, 2026 16:55
@jsha jsha requested a review from a team as a code owner June 5, 2026 16:55
@jsha jsha requested review from aarongable and removed request for a team June 5, 2026 16:55
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2026

@jsha, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values.

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2026

@jsha, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values.

aarongable
aarongable previously approved these changes Jun 5, 2026
Comment thread cmd/boulder-ra/main.go
vac := vapb.NewVAClient(vaConn)
caaClient := vapb.NewCAAClient(vaConn)

profileToMTCA := make(map[string]mtcapb.MTCAClient)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future there may be multiple profiles that all map to the same MTCA, which would necessitate rewriting how the loop below populates this map, but this is definitely good enough for now.

Comment thread mtca/mtca.go
func New(issuer *issuance.Issuer) *mtca {
return &mtca{
issuer: issuer,
logID: issuer.Cert.Subject.String(),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is truly the logID, and not the caID, then shouldn't it be fmt.Sprintf("%s.0.%d", issuer.Cert.Subject.String(), logGeneration)?

Comment thread ra/ra.go
return nil, err
}

ra.countCertificateIssued(ctx, order.RegistrationID, idents, isRenewal)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll eventually want this metric to indicate that this was an MTC issuance, probably, but totally fine as-is for now.

Base automatically changed from boulder-mtca2 to main June 5, 2026 20:07
@jsha jsha dismissed aarongable’s stale review June 5, 2026 20:07

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants