SRCADM-01 准入绑定:授权一次 EVGAP-01 抽取(四项条件不变) - #66
Merged
Conversation
…1 run Exactly the three steps the reviewer prescribed: update SRCADM-01's admission status and record reference, point EVGAP-01's admission_record_ref at the #63 review record merged by #65, and authorise one EVGAP-01 extraction with the four conditions unchanged. grants_admission_by_itself stays false on purpose. Admission is not granted by that file; it is granted by the review record the file now points at. authorises_level_01_execution stays false, and the new authorises_extraction_run_count caps the grant at a single run. Tests now assert the referenced record actually exists and names this dataset, version and snapshot, and that EVGAP-01's condition list equals the four SRCADM-01 froze, so the two cannot drift apart. Two notes recorded rather than glossed. PR #59's frozen record-path pattern names the file after the dataset, while the approved record #65 merged names it after the admission ID; the pattern was realigned instead of renaming a merged, already-referenced record. And an unquoted not_authorised entry let YAML read " #59 ..." as a comment, silently reducing it to "扩大 PR" — fixed here because this PR rewrote that list anyway. Three more instances of that defect exist in files this PR does not touch and are left alone as unrelated changes. No extraction was run, no gap lifted, no target axis change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
依据 PR #63
APPROVE(记录logs/chatgpt-review-2026-08-06-srcadm-01-admission-final.md,由 #65 合入)。只做审核方指定的三件事。
变更
srcadm_01…statuspending_reviewapprovedsrcadm_01…admission_record_refnullsrcadm_01…grants_admission_by_itselffalsefalse(未变)evgap_01…admission_statuspending_separate_admission_pradmitted_with_conditionsevgap_01…admission_record_refnullevgap_01…authorises_extraction_runfalsetrueevgap_01…extraction_blocked_by[SRCADM-01][]evgap_01…authorises_level_01_executionfalsefalse(未变)grants_admission_by_itself保持false是有意的:准入不是这个文件授予的,是它指向的那条审核记录授予的。新增
authorises_extraction_run_count: 1——授权是一次抽取。四项条件原样承接
EVGAP-01侧新增admission_is_conditional: true与admission_conditions: [COND-01..04],测试断言该列表与
SRCADM-01冻结的四项逐项相等,防止两边漂移;并断言
admission_record_ref指向的文件确实存在且内容含该 dataset/version/snapshot/APPROVE——悬空指针不得放行抽取。
两处主动说明,未静默处理
1. 记录文件命名形态不一致。 PR #59 冻结的 pattern 按数据集命名,
而 #65 已合入并获批的记录按 admission ID 命名。
未重命名已被引用的审核记录,改为对齐形态并以
admission_record_path_pattern_superseded保留原形态。2. 一个既有 YAML 缺陷。
- 扩大 PR #59 的字段白名单未加引号,YAML 把
#59 …当注释,该条目在机器可读层面静默退化为「扩大 PR」。本 PR 因绑定本就要重写该表,故一并加引号修正。
同类缺陷另有三处未修(无关改动):
adc_pool_level_01_input_binding.yaml…绑定到 PRevgap_01_surface_localization_extraction.yaml把被隔离运行(PRevgap_02_crc_linkage_extraction.yaml把被隔离运行(PR影响有界:原文对人类可读,丢的只是解析后内容,现有测试断言的是其他条目。
建议另开极小 PR 统一加引号并加防回归检查。
本 PR 不做什么
不执行
EVGAP-01抽取;不执行 Level 01;不解除任何缺口;不改 target 轴;不碰
EVGAP-02契约;不扩大字段白名单;不纳入SRCADM-02..05。Ran 372 testsOK,boundary check 通过,7 个变异全部被捕获(悬空记录引用、授权次数放大、悄悄放行 Level 01、条件缺失、条件性移除、
阻断项复现却仍授权、admission_status 降级)。
本 PR 不适用
AGENTS.md「审核豁免」。