Skip to content
This repository was archived by the owner on Dec 16, 2024. It is now read-only.

Add missing scripts #1

Open
namfal wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add missing scripts #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
911ad92
Add the launchnotes widget scripts to index.html
namfal May 26, 2023
dffaa56
id should not have the pound sign (#) in front of it
namfal May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
work correctly both with client-side routing and a non-root public URL.
Learn how to configure a non-root public URL by running `npm run build`.
-->
<script type="module" async="" src="https://embed.launchnotes.io/latest/dist/esm/launchnotes-embed.js"></script>
<script nomodule="" async="" src="https://embed.launchnotes.io/latest/dist/esm/launchnotes-embed.js"></script>
<title>React App</title>
</head>
<body>
Expand Down
2 changes: 1 addition & 1 deletion src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ function App() {
return (
<div className="App">
<h2>Pop-up Embed</h2>
<button key={'whats-new-launchnotes'} id="#whats-new-launchnotes">Click Me</button>
<button key={'whats-new-launchnotes'} id="whats-new-launchnotes">Click Me</button>
<launchnotes-embed
project={process.env.PRODUCTION_META}
token={process.env.PRODUCTION_META_PUBLIC_TOKEN}
Expand Down