Skip to content
This repository was archived by the owner on Dec 16, 2024. It is now read-only.

Add missing scripts#1

Open
namfal wants to merge 2 commits into
launchnotes:mainfrom
namfal:main
Open

Add missing scripts#1
namfal wants to merge 2 commits into
launchnotes:mainfrom
namfal:main

Conversation

@namfal

@namfal namfal commented May 26, 2023

Copy link
Copy Markdown

Hi there,

I am trying to embed the Launch Notes Widget into a react app and came across your example (which was very helpful). For some reason, it didn't work right from the start for me.

On the NPM readme, it says to use the following script when self hosting the widget, but this didn't work either (I think the package needs an update).

<script src='node_modules/@launchnotes/embed/dist/launchnotes-embed.js'></script>

So instead, I added the following scripts from here.

<script type="module" async="" src="https://embed.launchnotes.io/latest/dist/esm/launchnotes-embed.js"></script>
<script nomodule="" async="" src="https://embed.launchnotes.io/latest/dist/esm/launchnotes-embed.js"></script>

I also noticed that there was an unnecessary # in the ID of the trigger. With these changes, it works for me (granted the project and token is correct).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant