Skip to content

feat/video chapters#65

Draft
nmpereira wants to merge 3 commits into
labrocadabro:mainfrom
nmpereira:feat/video-chapters
Draft

feat/video chapters#65
nmpereira wants to merge 3 commits into
labrocadabro:mainfrom
nmpereira:feat/video-chapters

Conversation

@nmpereira
Copy link
Copy Markdown
Contributor

@nmpereira nmpereira commented Jan 13, 2024

closes #61

depends on #64 (copyLink.js is reworked)

Add support for chapters/timestamps

  • Reused the existing (unused) timestamps in the dbmodel/edit class page
  • fixed bug with the existing timestamp input in the edit class page where, when a single timestamp was newly added, it formatted it incorrectly on the db
  • added a chapter component on the class page that's scrollable
  • in the chapters component, added support for clicking on a specific chapter to go to that specific time in the video (with no page refresh)
  • in the chapters component, added support for feedback when user clicks the copy button to copy a chapter (copies the link)

screenshots

Edit class page
image

Lesson page
image

image

Comment thread src/assets/js/copyLink.js
}
}

// copyBtn.addEventListener("click", async () => {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intentionally commented out because this code is reworked from another PR

@nmpereira nmpereira mentioned this pull request Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chapters for videos

1 participant