Skip to content

feat/timestamp link#64

Open
nmpereira wants to merge 4 commits into
labrocadabro:mainfrom
nmpereira:feat/timestamp-link
Open

feat/timestamp link#64
nmpereira wants to merge 4 commits into
labrocadabro:mainfrom
nmpereira:feat/timestamp-link

Conversation

@nmpereira
Copy link
Copy Markdown
Contributor

@nmpereira nmpereira commented Jan 13, 2024

closes #58

  • Added support to start the video if a query t=seconds is in the link. Example:url&t=50
  • Added button on class page to copy link at current timestamp to the clipboard

Notes:

  • when a user is logged into their youtube account and have youtube history enabled, the youtube history overrides the timestamp provided in the URL. In my opinion, this should be a separate issue. From working on feat/video chapters #65, seeking via js does seem possible. This will require another attempt in a future PR
    player.seekTo(btn.dataset.time);

screenshots

image

Button to copy link
image

Animation when button is clicked
image

Comment thread src/assets/js/copyLink.js
copyBtn.innerHTML = "Copied!";

// reset button text after 3 seconds
setTimeout(() => {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a little animation here that gives some user feedback

@nmpereira nmpereira marked this pull request as ready for review January 13, 2024 03:22
@nmpereira nmpereira changed the title Feat/timestamp link feat/timestamp link Jan 13, 2024
@nmpereira nmpereira mentioned this pull request Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support timestamps on video pages

1 participant