Skip to content

Update fr#121

Closed
Benjamin45590 wants to merge 1 commit into
kmich:mainfrom
Benjamin45590:patch-37
Closed

Update fr#121
Benjamin45590 wants to merge 1 commit into
kmich:mainfrom
Benjamin45590:patch-37

Conversation

@Benjamin45590

Copy link
Copy Markdown
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist:

  • My code follows the code style of this project
  • I have updated the documentation accordingly (if needed)
  • I have added tests to cover my changes (if applicable)
  • All new and existing tests passed
  • I have updated CHANGELOG.md with my changes

@Benjamin45590 Benjamin45590 changed the title Update print statement from 'Hello' to 'Goodbye' Update fr Jun 30, 2026
kmich added a commit that referenced this pull request Jul 1, 2026
…ing en strings (#122)

* Update config_flow.py

* Update print statement from 'Hello' to 'Goodbye'

* fix(translations): add missing English strings for initial-setup indoor rooms

PR #120 added new config-flow steps (indoor_rooms, room_edit, room_form,
room_remove) and a room_name_required error for configuring named indoor
rooms during initial setup, but only PR #121 added translations (French
only). Add the matching strings.json/en.json entries so the flow renders
correctly in English and hassfest translation checks pass.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* test(config_flow): exempt indoor-room CRUD mini-wizard from back-button checks

PR #120's new initial-setup indoor room steps (indoor_rooms hub, room_add/
edit/form/remove/done) bypass the linear back-button convention the same
way the identical, already-shipped room_* steps in the Options flow's
indoor_rooms_opt hub do: the hub is a menu (no data schema to carry a
_go_back field) and the CRUD sub-forms loop back to their own hub rather
than the outer step sequence. Exempt them explicitly instead of leaving
CI red.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* chore: release 2.6.1

Initial-setup indoor rooms (PR #120), the Vigicrues/Indoor Options-flow
ordering fix, and the missing English translations for the new steps.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

---------

Co-authored-by: Benjamin45590 <102737733+Benjamin45590@users.noreply.github.com>
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
@kmich kmich closed this in #122 Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant