fix(translations): add named indoor rooms to initial setup + fix missing en strings#122
Merged
Conversation
…or rooms PR #120 added new config-flow steps (indoor_rooms, room_edit, room_form, room_remove) and a room_name_required error for configuring named indoor rooms during initial setup, but only PR #121 added translations (French only). Add the matching strings.json/en.json entries so the flow renders correctly in English and hassfest translation checks pass. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…on checks PR #120's new initial-setup indoor room steps (indoor_rooms hub, room_add/ edit/form/remove/done) bypass the linear back-button convention the same way the identical, already-shipped room_* steps in the Options flow's indoor_rooms_opt hub do: the hub is a menu (no data schema to carry a _go_back field) and the CRUD sub-forms loop back to their own hub rather than the outer step sequence. Exempt them explicitly instead of leaving CI red. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Initial-setup indoor rooms (PR #120), the Vigicrues/Indoor Options-flow ordering fix, and the missing English translations for the new steps. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
strings.json/translations/en.jsonentries for the new config-flow steps (indoor_rooms,room_edit,room_form,room_remove) and theroom_name_requirederror, which Update config_flow.py #120 introduced in code but never added English strings for. Update fr #121 only added the French side.Verified
config.step/config.errorkey sets now match exactly acrossstrings.json,translations/en.json, andtranslations/fr.json.Closes #120, closes #121.
Test plan
python -m py_compile custom_components/ws_core/config_flow.pyconfig.step/config.errorkeys match across strings.json, en.json, fr.json