feat(hive): spike — window.hive_keychain shim + HIVE transfer (fw 7.15.0)#106
Merged
Conversation
…oneer (fw 7.15.0 gate) - injected: Keychain-compatible window.hive_keychain (requestHandshake + requestTransfer; the rest fail keychain-style so dApps degrade gracefully), mounted only when the real Keychain is absent - background: hiveHandler — pubkey via vault POST /addresses/hive (SLIP-0048 m/48'/13'/1'/0'/0'), account/tx-params/broadcast via Pioneer, signing via new vault POST /hive/sign-transfer (device serializes + signs) - firmware gate: requireHiveFirmware (7.15.0), parametrized meetsMin - chain config: hive:beeab0de / slip44:1275 maps; approval UI routes hive to the generic OtherTransaction view Depends on vault branch feature/hive-rest-sign (POST /hive/sign-transfer). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… safety, approval render, state reset, full stub surface
- injected: mount window.hive_keychain as a plain writable property so the
real Hive Keychain (document_idle) can replace our shim; stub all 29
remaining Keychain request* methods so none throw TypeError
- handler: reject encrypted ('#') memos instead of leaking plaintext
on-chain; exact decimal-string amount validation (no parseFloat coercion
or rounding); currency now required; reject username mismatch (enforce
semantics — we control one account); unsignedTx.payment shaped for
RequestDetailsCard (destination/amount/decimals/symbol + caip)
- lifecycle: resetHiveState() wired into all three device reset sites
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…sername
- return { id, tx_id, confirmed } (matches hive-tx.utils.ts) instead of
{ txid } so dApps reading response.result.id / .tx_id work
- enforce=true with no username is malformed — reject with -32602
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Browser-extension side of Hive support, gated on firmware 7.15.0:
window.hive_keychainshim (requestHandshake+requestTransfer; all other Keychain methods return keychain-stylesuccess:falseso dApps degrade gracefully). Mounted only when the real Hive Keychain is absent.hiveHandler.ts— STM pubkey via vaultPOST /addresses/hive(SLIP-0048m/48'/13'/1'/0'/0', matching firmware/Ledger), account resolution + tx-params + broadcast via Pioneer (api.keepkey.info/api/v1/hive/*, all confirmed live), signing via new vaultPOST /hive/sign-transfer.requireHiveFirmware(7.15.0),meetsMinparametrized.hive:beeab0de/slip44:1275maps; approval UI routes hive through the generic OtherTransaction view.Depends on
feature/hive-rest-sign(addsPOST /hive/sign-transfer) — extension transfer signing 404s against older vaults.hive_enabledsetting.Verification
pnpm type-check(15/15) andmake buildpass; hive code confirmed indist/injected.js+ background bundle.🤖 Generated with Claude Code