feat(hive): REST endpoint POST /hive/sign-transfer for BEX/SDK clients#356
Merged
Conversation
Exposes the existing wallet.hiveSignTx (device-serialized Graphene transfer, fw 7.15.0+) over REST so the browser extension can sign Hive transfers the same way it signs Solana/Tron/TON. Gated identically to /addresses/hive (hive_enabled flag → 403, firmware < 7.15.0 → 501) and registered in SIGNING_ROUTES so the Vault approval overlay + empty-probe rejection apply. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes the existing
wallet.hiveSignTx(device-serialized Graphene transfer, fw 7.15.0+) over REST so the browser extension can sign Hive transfers the same way it signs Solana/Tron/TON./addresses/hive:hive_enabledflag → 403, firmware < 7.15.0 → 501SIGNING_ROUTES+requiredSigningFieldsso the Vault approval overlay and empty-probe rejection apply (the sign-gating regression test picks it up automatically)ROUTE_TO_CHAINgetshive: 'HIVE'for activity trackinghiveRolePath('active', 0)when the caller omitsaddress_nConsumer: keepkey-client PR keepkey/keepkey-client#106 (window.hive_keychain shim).
Verification:
bun buildof the three touched files compiles;make test-sign-gatingenumerates the new route but needs a vault restarted from this branch (the running 1646 instance predates the route — the two hive-route test failures are 404s from the stale instance). Draft until live-verified.