Skip to content

ci(release): skip delta production when DB schema changes #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kdroidFilter wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ci(release): skip delta production when DB schema changes #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/manual-generate-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,22 @@ jobs:
PREV_DB=$(find prev-dbs/extract -name seforim.db -type f | head -n1)
test -s "$PREV_DB" || { echo "::error::seforim.db not found in bundle of $TAG"; exit 1; }

# Skip the delta whenever the schema changed: a delta can only carry
# data (upserts/deletes), not schema migrations. If prev and new
# don't have identical table/index DDL, clients on $TARGET_VER must
# re-download the full bundle — so we don't produce (or fail CI on)
# a patch for this offset.
schema_of() {
sqlite3 "$1" \
"SELECT sql FROM sqlite_master WHERE type IN ('table','index') AND sql IS NOT NULL ORDER BY name;" \
| tr -s '[:space:]' ' '
}
if [ "$(schema_of "$PREV_DB")" != "$(schema_of "$PWD/build/seforim.db")" ]; then
echo "::notice::Schema differs v${TARGET_VER} → v${THIS_VER} — skipping delta, clients fall back to full bundle"
rm -rf prev-dbs
continue
fi

./gradlew :generator-common:producePatchAndVerify \
-PprevDb=$PWD/$PREV_DB \
-PnewDb=$PWD/build/seforim.db \
Expand Down
Loading