ci(release): skip delta production when DB schema changes#87
Open
kdroidFilter wants to merge 1 commit into
Open
ci(release): skip delta production when DB schema changes#87kdroidFilter wants to merge 1 commit into
kdroidFilter wants to merge 1 commit into
Conversation
A delta patch carries only data (upserts/deletes), not schema migrations. When prev and new seforim.db have different table/index DDL, producing a patch fails or mismatches. Compare the schemas in the patch-fan step and skip that offset on any difference — clients on the affected version fall back to the full bundle (the manifest's native behavior when no covering delta exists). Keeps CI green across schema changes without adding any migration logic to the producer.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
seforim.dbhave different table/index DDL, the producer fails or produces a hash-mismatch.sqlite_masterDDL) before invoking the producer, and skips that offset on any difference.Net effect:
This makes the
ADD COLUMNmigration approach (PR #84) unnecessary.