Skip to content

fix(generator): don't abort the build on unmatched generation titles #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kdroidFilter merged 1 commit into from
Jun 26, 2026
Merged

fix(generator): don't abort the build on unmatched generation titles #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .../kotlin/io/github/kdroidfilter/seforimlibrary/sefariasqlite/SeedGenerationsPostProcess.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,14 @@ private fun applyGenerations(
linksCreated += linkStmt.executeUpdate()
}
}
require(unmatchedTitles.isEmpty()) {
"Generation CSV has ${unmatchedTitles.size} unmatched book title(s): " +
unmatchedTitles.take(20).joinToString()
// Don't abort the whole build when generations.csv references books that are
// not in the current library (upstream otzaria-library vs ForDB drift): keep
// every link that DID match and just warn about the rest.
if (unmatchedTitles.isNotEmpty()) {
logger.w {
"Generation CSV has ${unmatchedTitles.size} unmatched book title(s) (skipped): " +
unmatchedTitles.take(20).joinToString()
}
}
return GenerationApplyResult(generationsCreated, linksCreated, 0)
}
Expand Down
Loading