fix(generator): don't abort the build on unmatched generation titles#86
Merged
Merged
Conversation
seedGenerations called require(unmatchedTitles.isEmpty()), so the whole DB build failed whenever generations.csv (ForDB) referenced a book missing from the current otzaria-library — an upstream drift between the two sources. Keep every generation link that matched and log a warning for the rest instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
seedGenerationsaborted the entiregenerateSeforimDbpipeline viarequire(unmatchedTitles.isEmpty())whenevergenerations.csv(ForDB) referenced a book title that isn't in the currentotzaria-library. The two sources are fetched independently ("latest"), so any upstream drift (a renamed/removed book) hard-fails the whole build — e.g. "Generation CSV has 37 unmatched book title(s): מעדני יום טוב על ברכות, …".This keeps every generation link that did match and logs a warning for the unmatched ones instead of throwing.
require(unmatchedTitles.isEmpty())→if (unmatchedTitles.isNotEmpty()) logger.w { … }Test plan
generateSeforimDbcompletes whengenerations.csvreferences missing books (warns, doesn't abort).book_generationpopulated).