build(deps): Bump mjml from 4.18.0 to 5.0.0 in /scripts - #653
Merged
Conversation
dependabot
Bot
added
dependencies
Contributor
|
📈 This is how your metrics evolved 📉 |
Bumps [mjml](https://github.com/mjmlio/mjml/tree/HEAD/packages/mjml) from 4.18.0 to 5.0.0. - [Release notes](https://github.com/mjmlio/mjml/releases) - [Commits](https://github.com/mjmlio/mjml/commits/v5.0.0/packages/mjml) --- updated-dependencies: - dependency-name: mjml dependency-version: 5.0.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Jeremie Drouet <jeremie.drouet@gmail.com>
Signed-off-by: Jeremie Drouet <jeremie.drouet@gmail.com>
jdrouet
force-pushed
the
dependabot/npm_and_yarn/scripts/mjml-5.0.0
branch
from
July 30, 2026 07:58
575b43a to
991cf96
Compare
Open
jdrouet
added a commit
that referenced
this pull request
Jul 30, 2026
Runs `npm audit fix` in scripts/, bumping four transitive packages: brace-expansion 2.1.0 -> 2.1.3 nanoid 3.3.15 -> 3.3.16 postcss 8.5.16 -> 8.5.25 svgo 4.0.1 -> 4.0.2 This clears three high severity advisories: GHSA-r28c-9q8g-f849 postcss path traversal in previous source map auto-loading GHSA-2p49-hgcm-8545 svgo removeScripts leaves some executable scripts intact GHSA-3jxr-9vmj-r5cp brace-expansion DoS via exponential-time expansion of consecutive non-expanding {} groups postcss and svgo arrived with the mjml 5 bump in #653, which pulled in the PostCSS/cssnano chain. GHSA-mh99-v99m-4gvg (brace-expansion, patched in 5.0.8) is deliberately left alone: the chain is mjml -> mjml-cli -> glob/minimatch -> brace-expansion, and mjml-cli has no release that unpins the vulnerable range, so this one needs an upstream fix first. Lockfile-only, and only affects the tooling that regenerates the comparison fixtures; nothing here ships to users. Regenerating all of packages/mrml-core/resources/compare/ against the new lockfile produces byte-identical output, so `resources check` stays green. Signed-off-by: Jeremie Drouet <jeremie.drouet@gmail.com>
jdrouet
added a commit
that referenced
this pull request
Jul 30, 2026
…le (#664) Runs `npm audit fix` in `scripts/`, bumping four transitive packages: | package | from | to | |---|---|---| | `brace-expansion` | 2.1.0 | 2.1.3 | | `nanoid` | 3.3.15 | 3.3.16 | | `postcss` | 8.5.16 | 8.5.25 | | `svgo` | 4.0.1 | 4.0.2 | ## Advisories cleared | advisory | package | summary | |---|---|---| | [GHSA-r28c-9q8g-f849](GHSA-r28c-9q8g-f849) | `postcss` | Path traversal in previous source map auto-loading (`sourceMappingURL`) leads to arbitrary `.map` file disclosure | | [GHSA-2p49-hgcm-8545](GHSA-2p49-hgcm-8545) | `svgo` | `removeScripts` plugin leaves some executable scripts intact | | [GHSA-3jxr-9vmj-r5cp](GHSA-3jxr-9vmj-r5cp) | `brace-expansion` | DoS via exponential-time expansion of consecutive non-expanding `{}` groups | `postcss` and `svgo` arrived with the mjml 5 bump in #653, which pulled in the PostCSS/cssnano chain. ## Knowingly left open [GHSA-mh99-v99m-4gvg](GHSA-mh99-v99m-4gvg) (`brace-expansion`, patched in 5.0.8) is **not** fixed here. The chain is `mjml` → `mjml-cli` → `glob`/`minimatch` → `brace-expansion`, and `mjml-cli` has no release that unpins the vulnerable range — `npm audit` reports it as `mjml-cli <=5.2.2`. It needs an upstream fix first; `npm audit fix --force` would only "resolve" it by downgrading mjml. ## Scope and verification Lockfile-only, and it only affects the tooling that regenerates the comparison fixtures — nothing here ships to users. Regenerating the whole of `packages/mrml-core/resources/compare/` against the new lockfile produces **byte-identical output** (0 files changed), so `resources check` stays green. Signed-off-by: Jeremie Drouet <jeremie.drouet@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps mjml from 4.18.0 to 5.0.0 in
/scripts, and aligns mrml's own output with it.scripts/generates the expected HTML inpackages/mrml-core/resources/compare/, so an mjml major bump is a change to the reference output mrml is tested against. Two follow-up commits adapt to it:fix(scripts): await async mjml2html for mjml v5— mjml 5 mademjml2htmlasync (PostCSS/cssnano), soupdate-resources.jsnow awaits the result instead of reading.htmloff a promise.feat(render): align mj-body and mj-hero output with mjml v5— this changes rendered output for all mrml users:mj-body:word-spacing:normalnow applies to both the<body>tag and the content<div>(previously<body>only), andcss-classmoves from the content<div>to the<body>tag.mj-hero: the Outlook-only inner table and its width attribute now use the container width minus horizontal padding, rather than the full container width.All 156 changed comparison fixtures were regenerated;
resources checkconfirms they match mjml 5's output and the mrml-core suite confirms mrml matches the fixtures.Bumps mjml from 4.18.0 to 5.0.0.
Release notes
Sourced from mjml's releases.
... (truncated)
Commits
ddb2335v5.0.09aac8c6v5.0.0-beta.21dfbc95v5.0.0-beta.165e81dav5.0.0-alpha.1174f3577Merge pull request #3045 from mjmlio/bugfix/3018-mjml5-ignoreIncludes-allowIn...b8e6a60Merge pull request #3044 from mjmlio/bugfix/attributes-adding-updating-for-co...2eb56d7feature(includes): implemented tighter controls591fd1ebugfix(ignoreIncludes): updated test files6b22a67feature(ignoreIncludes): added option for includePath9b7991fbugfix(border-radius): accept string inputDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.