fix(deps-dev): resolve high severity advisories in the scripts lockfile - #664
Merged
Conversation
|
Runs `npm audit fix` in scripts/, bumping four transitive packages: brace-expansion 2.1.0 -> 2.1.3 nanoid 3.3.15 -> 3.3.16 postcss 8.5.16 -> 8.5.25 svgo 4.0.1 -> 4.0.2 This clears three high severity advisories: GHSA-r28c-9q8g-f849 postcss path traversal in previous source map auto-loading GHSA-2p49-hgcm-8545 svgo removeScripts leaves some executable scripts intact GHSA-3jxr-9vmj-r5cp brace-expansion DoS via exponential-time expansion of consecutive non-expanding {} groups postcss and svgo arrived with the mjml 5 bump in #653, which pulled in the PostCSS/cssnano chain. GHSA-mh99-v99m-4gvg (brace-expansion, patched in 5.0.8) is deliberately left alone: the chain is mjml -> mjml-cli -> glob/minimatch -> brace-expansion, and mjml-cli has no release that unpins the vulnerable range, so this one needs an upstream fix first. Lockfile-only, and only affects the tooling that regenerates the comparison fixtures; nothing here ships to users. Regenerating all of packages/mrml-core/resources/compare/ against the new lockfile produces byte-identical output, so `resources check` stays green. Signed-off-by: Jeremie Drouet <jeremie.drouet@gmail.com>
jdrouet
force-pushed
the
chore/scripts-audit-fix
branch
from
July 30, 2026 08:23
f95cc79 to
c3d53d0
Compare
This was referenced Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs
npm audit fixinscripts/, bumping four transitive packages:brace-expansionnanoidpostcsssvgoAdvisories cleared
postcsssourceMappingURL) leads to arbitrary.mapfile disclosuresvgoremoveScriptsplugin leaves some executable scripts intactbrace-expansion{}groupspostcssandsvgoarrived with the mjml 5 bump in #653, which pulled in the PostCSS/cssnano chain.Knowingly left open
GHSA-mh99-v99m-4gvg (
brace-expansion, patched in 5.0.8) is not fixed here. The chain ismjml→mjml-cli→glob/minimatch→brace-expansion, andmjml-clihas no release that unpins the vulnerable range —npm auditreports it asmjml-cli <=5.2.2. It needs an upstream fix first;npm audit fix --forcewould only "resolve" it by downgrading mjml.Scope and verification
Lockfile-only, and it only affects the tooling that regenerates the comparison fixtures — nothing here ships to users.
Regenerating the whole of
packages/mrml-core/resources/compare/against the new lockfile produces byte-identical output (0 files changed), soresources checkstays green.