fix: complete open AgentBoard ticket batch#135
Merged
Conversation
This was referenced May 25, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR completes a batch of open AgentBoard tickets by improving Work board state persistence, create-issue UX behavior, and session/terminal integrations (including tmux-backed completion detection and embedded terminal access where available).
Changes:
- Persist Work board repository selection per scene and seed the Create Issue sheet with an initial repository when possible.
- Make Create Issue sheet dismissal depend on the returned created item (instead of
errorMessage == nil) by returningWorkItem?fromWorkStore.createIssue. - Improve session UX by auto-opening newly launched session terminals, adding an embedded terminal tab for tmux-backed sessions, and detecting completion/failure via tmux
EXITED:output.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| AGENTS.md | Adds activity log entry for the completed ticket batch. |
| AgentBoardUI/Screens/WorkScreen.swift | Uses @SceneStorage for repo selection; seeds Create Issue with a repository; resets selection when repos change. |
| AgentBoardUI/Screens/SessionDetailSheet.swift | Adds a conditional “Terminal” tab and renders an embedded terminal when tmux session is available (macOS + SwiftTerm). |
| AgentBoardUI/Screens/CreateIssueSheet.swift | Accepts an initial repository, normalizes selection as repos change, and dismisses only on successful creation return. |
| AgentBoardCore/Stores/WorkStore.swift | Changes createIssue to return WorkItem? and marks it @discardableResult. |
| AgentBoardCore/Services/SessionLauncher.swift | Parses tmux pane output for EXITED: to classify sessions as completed/failed. |
| AgentBoard/DesktopRootView.swift | Tracks observed session IDs and auto-opens the newest launched session terminal. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+85
to
+91
| .onChange(of: appModel.settingsStore.repositories) { _, repositories in | ||
| guard selectedRepo != "all", | ||
| !repositories.contains(where: { $0.fullName == selectedRepo }) else { | ||
| return | ||
| } | ||
| selectedRepo = "all" | ||
| } |
| - (no commits) | ||
|
|
||
| ## Activity — 2026-05-25 | ||
| - Fixed open ticket batch #130-#133: Work board repository selection now persists per scene and seeds create-issue sheets; create issue dismisses based on a successful created item; launched sessions auto-open the terminal; tmux `EXITED:` output now drives completed/failed state; companion-backed session details expose an interactive terminal tab when a tmux session is available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.