Fix GGD ruleset causing CI failure#18
Merged
paulotex merged 7 commits intoJun 19, 2026
Merged
Conversation
SBlokhuizen
marked this pull request as ready for review
June 9, 2026 13:22
maarten-ic
reviewed
Jun 9, 2026
maarten-ic
approved these changes
Jun 9, 2026
Contributor
Author
|
Hi @paulotex this PR implements some bugfixes for GGD ruleset. Could you see if you have any comments and if not, could you merge this PR? Thanks! |
paulotex
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR duplicates the first three commits of PR #13, which was previously approved but it was accidentally deleted and never merged.
The new commits (04050dc, cd6b7f3) update the minimum required version of IMAS-Python such that IMAS-Core is always available. Also the CI check for python 3.9 was removed, as this version is past its end-of-life and no wheels for IMAS-Core are available for this version.