Fix compatibility with imas-python >= 2.2#20
Closed
DaanVanVugt wants to merge 1 commit into
Closed
Conversation
imas-python 2.2 removed the has_imas attribute, and importing imas.backends.imas_core.imas_interface now raises ImportError when imas_core is not installed (iterorganization/IMAS-Python#92), crashing _check_imas_version with AttributeError. Detect the access layer by importing ll_interface and checking _al_version instead, which works on both old and new imas-python. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Author
|
#18 also fixes that issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
imas-python 2.2 removed the has_imas attribute, and importing imas.backends.imas_core.imas_interface now raises ImportError when imas_core is not installed (iterorganization/IMAS-Python#92), crashing _check_imas_version with AttributeError.
Detect the access layer by importing ll_interface and checking _al_version instead, which works on both old and new imas-python.