Cleanup unit tests: remove checks for imas-core#92
Merged
olivhoenen merged 6 commits intoJan 8, 2026
Merged
Conversation
prasad-sawantdesai
requested review from
maarten-ic and
olivhoenen
as code owners
January 6, 2026 09:34
maarten-ic
requested changes
Jan 6, 2026
maarten-ic
left a comment
maarten-ic
left a comment
Collaborator
There was a problem hiding this comment.
CI has >100 failures and errors, can you have a look what's wrong and update the PR accordingly?
SimonPinches
approved these changes
Jan 6, 2026
Collaborator
Author
Yes, testing with MDSplus is skipped as imas_core Python package does not support the MDSplus backend. |
maarten-ic
requested changes
Jan 7, 2026
maarten-ic
left a comment
maarten-ic
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! I also checked the remainder of conftest and there's some more pieces that can probably be removed. Could you have a look at those as well?
maarten-ic
approved these changes
Jan 7, 2026
maarten-ic
left a comment
maarten-ic
left a comment
Collaborator
There was a problem hiding this comment.
Great, nice cleanup of the code! :)
olivhoenen
approved these changes
Jan 8, 2026
olivhoenen
pushed a commit
that referenced
this pull request
Feb 12, 2026
DaanVanVugt
added a commit
to DaanVanVugt/IMAS-Validator
that referenced
this pull request
Jun 11, 2026
imas-python 2.2 removed the has_imas attribute, and importing imas.backends.imas_core.imas_interface now raises ImportError when imas_core is not installed (iterorganization/IMAS-Python#92), crashing _check_imas_version with AttributeError. Detect the access layer by importing ll_interface and checking _al_version instead, which works on both old and new imas-python. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup: Remove IMAS availability checks from test fixtures #91