-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[Fix] AppLauncher: terminate on SIGTERM #6531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RX-02333
wants to merge
4
commits into
isaac-sim:develop
Choose a base branch
from
RX-02333:rx-02333/fix-sigterm-shutdown
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3762aa9
Fix AppLauncher SIGTERM shutdown
RX-02333 d92765b
Merge branch 'develop' into rx-02333/fix-sigterm-shutdown
RX-02333 f99f0c7
Merge branch 'develop' into rx-02333/fix-sigterm-shutdown
RX-02333 3b94443
Merge branch 'develop' into rx-02333/fix-sigterm-shutdown
RX-02333 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
source/isaaclab/changelog.d/rx-02333-fix-sigterm-shutdown.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| Fixed | ||
| ^^^^^ | ||
|
|
||
| * Fixed :class:`~isaaclab.app.AppLauncher` leaving Python processes | ||
| running after receiving ``SIGTERM``. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # Copyright (c) 2022-2026, The Isaac Lab Project Developers (https://github.com/isaac-sim/IsaacLab/blob/main/CONTRIBUTORS.md). | ||
| # All rights reserved. | ||
| # | ||
| # SPDX-License-Identifier: BSD-3-Clause | ||
|
|
||
| import signal | ||
|
|
||
| import pytest | ||
|
|
||
| from isaaclab.app import AppLauncher | ||
|
|
||
|
|
||
| def test_sigterm_handler_terminates_process(): | ||
| """SIGTERM must terminate Python instead of resuming after the handler.""" | ||
| with pytest.raises(SystemExit) as exc_info: | ||
| AppLauncher._terminate_signal_handle_callback(signal.SIGTERM, None) | ||
|
|
||
| assert exc_info.value.code == 128 + signal.SIGTERM | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test exercises
_terminate_signal_handle_callbackdirectly, confirming theSystemExit(143)path. It does not assert thatsignal.getsignal(signal.SIGTERM)actually points to this method afterAppLauncherinitialises. If the registration line were accidentally reverted or guarded behind a condition, the test would still pass. A complementary integration-level assertion (e.g. checkingsignal.getsignal(signal.SIGTERM)after constructing anAppLauncher) would close this gap, though doing so requires the full Isaac Sim environment.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!