-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[MGPU] App: default Kit renderer to one GPU #5933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hujc7
merged 6 commits into
isaac-sim:develop
from
hujc7:jichuanh/mgpu-pin-kit-resources
Jul 7, 2026
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
22bf040
Add ISAACLAB_PIN_KIT_GPU to pin Kit renderer to one GPU
hujc7 0850bb6
Merge remote-tracking branch 'origin/develop' into jichuanh/mgpu-pin-…
hujc7 b052616
Refine Kit multi-GPU controls
hujc7 92cfa43
Move renderer multi-GPU defaults to Kit
hujc7 edc66a0
Merge remote-tracking branch 'origin/develop' into jichuanh/mgpu-pin-…
hujc7 b608df6
Deduplicate renderer GPU limits
hujc7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
source/isaaclab/changelog.d/jichuanh-mgpu-pin-kit-resources.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| Changed | ||
| ^^^^^^^ | ||
|
|
||
| * Changed the Isaac Lab Kit experiences to use one renderer GPU by default. To | ||
| enable single-process multi-GPU rendering, pass the ``renderer.multiGpu`` | ||
| settings explicitly through :class:`~isaaclab.app.AppLauncher`'s ``kit_args``. | ||
|
|
||
| Added | ||
| ^^^^^ | ||
|
|
||
| * Added ``ISAACLAB_FABRIC_USE_GPU_INTEROP`` to override the corresponding PhysX | ||
| Fabric Kit setting without changing renderer multi-GPU behavior. The multi-GPU | ||
| CI override is a temporary workaround to remove after the underlying Kit/PhysX | ||
| problem is fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
were we able to figure out why this was needed for CI? ideally I think this flag should always be on.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly the performance impact (agent claiming ~5% but needs to be confirmed). The problem currently only repros on CI instances when running tests in parallel, which makes it hard to investigate. The goal is to eventually remove those so currently it's setup as a WAR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok let's create a ticket before merging this so that we keep track of the issue and remind us to remove this workaround.