-
Notifications
You must be signed in to change notification settings - Fork 3.8k
feat: add indexed fabric transform kernels for local/world matrix propagation #5675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
2cd7627
feat: add indexed fabric transform kernels for local/world matrix pro…
pv-nvidia 8bc2d83
test: convert fabric kernel tests to plain functions (no classes)
pv-nvidia df1eb91
test: rewrite fabric kernel tests with wp.array (no Fabric runtime deps)
pv-nvidia c350569
refactor: extract world↔local math into @wp.func for testability
pv-nvidia be75741
refactor: extract world↔local math into @wp.func for testability
pv-nvidia 45a87d5
refactor: inline @wp.func helpers, add __all__, sync with full-stack
pv-nvidia 1e16f46
Revert "refactor: inline @wp.func helpers, add __all__, sync with ful…
pv-nvidia c9dcf47
docs: update changelog wording ('Will be used by' → 'Used by')
pv-nvidia 48823b2
docs: fix changelog wording (Used by → Will be used by)
pv-nvidia 7a9f8c4
revert: remove wp.where refactor (unrelated to this PR)
pv-nvidia a51094f
test: replace scipy with warp builtins in fabric kernel test helper
pv-nvidia 14134c8
docs: remove dead ThreeDWorld link (domain squatted)
pv-nvidia 86b1819
Merge branch 'develop' into pv/indexed-fabric-kernels
pv-nvidia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| Added | ||
| ^^^^^ | ||
|
|
||
| * Added :func:`~isaaclab.utils.warp.fabric.decompose_indexed_fabric_transforms` | ||
| and :func:`~isaaclab.utils.warp.fabric.compose_indexed_fabric_transforms` | ||
| Warp kernels. They mirror the existing | ||
| ``decompose_fabric_transformation_matrix_to_warp_arrays`` / | ||
| ``compose_fabric_transformation_matrix_from_warp_arrays`` kernels but | ||
| operate on :class:`wp.indexedfabricarray`, so the view-to-fabric mapping | ||
| is baked into the array and the kernel just dereferences | ||
| ``ifa[view_index]`` instead of taking a separate ``mapping`` argument. | ||
| * Added :func:`~isaaclab.utils.warp.fabric.update_indexed_local_matrix_from_world` | ||
| and :func:`~isaaclab.utils.warp.fabric.update_indexed_world_matrix_from_local` | ||
| Warp kernels that propagate ``local = world * inv(parent)`` and | ||
| ``world = local * parent`` directly on Fabric storage matrices (no | ||
| explicit transposes). Will be used by | ||
| :class:`~isaaclab_physx.sim.views.FabricFrameView` to keep child world and | ||
| local matrices consistent across writes without round-tripping through USD. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.