Skip to content

fix(poller): held-LL None crash aborted the whole poll #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
illinigirl merged 1 commit into from
Jul 3, 2026
Merged

fix(poller): held-LL None crash aborted the whole poll #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion infra/lambda/poller/index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,10 @@ def filter_to_favoriters(
_held = held_ll_by_ride.get(ride_id)
_ll_beats_held = True
if _held:
_avail = _parse_iso(attr.get("ll", {}).get("return_start"))
# `or {}` — attr["ll"] is present-but-None for a held-LL
# ride with no current offer; .get(k, {}) would return
# None (default is only used on a MISSING key), crashing.
_avail = _parse_iso((attr.get("ll") or {}).get("return_start"))
_held_dt = _parse_iso(_held)
_ll_beats_held = bool(_avail and _held_dt and _avail < _held_dt)
if (
Expand Down
Loading