fix(poller): held-LL None crash aborted the whole poll#30
Merged
Conversation
…e had no LL offer
attr.get("ll", {}) returns None (not {}) when the "ll" key is PRESENT but
None — which is exactly a held-LL ride with no current offer (TRON, Seven
Dwarfs after Megan set her holds). .get("return_start") then ran on None
→ AttributeError → the exception propagated to the handler and ABORTED
the entire poll, so no alerts fired every 2 min until caught (a
CloudWatch alarm surfaced it).
Fix: `(attr.get("ll") or {})` — coerce present-but-None to {}. The
.get(key, default) default only applies to a MISSING key, not a None
value.
Follow-up worth doing: wrap the per-attraction alert body in try/except
so one ride's bug can never again silence ALL alerts (blast radius was
the whole poll).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
attr.get('ll', {}) returns None for a present-but-None ll (held-LL ride with no offer), crashing the poll. Fix: (attr.get('ll') or {}). Already hotfix-deployed.
🤖 Generated with Claude Code