Skip to content

fix(ui): replace remaining old-theme loading + error surfaces - #23

Merged
guarzo merged 1 commit into
mainfrom
fix/post-login-loading-teal
May 3, 2026
Merged

fix(ui): replace remaining old-theme loading + error surfaces#23
guarzo merged 1 commit into
mainfrom
fix/post-login-loading-teal

Conversation

@guarzo

@guarzo guarzo commented May 3, 2026

Copy link
Copy Markdown
Owner

Summary

Two screens still rendered with the pre-redesign palette and were jarring against the rest of the warm-slate system:

  • Post-login data-loading screen (Routes.jsx) used bg-gray-900 text-teal-200 with a plain "Loading..." paragraph. Swapped for the system LoadingScreen component, so it matches the boot loader.
  • ErrorFallback (ErrorBoundary.jsx) used text-red-600 heading, bg-gray-100 pre, and a bg-blue-500 button. Migrated to bg-surface-0, text-status-error heading, accent button, mono error pre with border-rule-1 hairline, capped at 65ch.

Also picked up local working-tree changes that were sitting around: a Tailwind 4 / Vitest 4 / react-toastify 11 lockfile resync, a small backend config touch, and a .claude/settings.local.json permissions tweak.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

    • EVE credentials can now be configured via environment variables with automatic fallback support.
    • Enhanced loading screen during authentication and data initialization.
  • Style

    • Updated error message display styling for improved readability and visual consistency.
  • Chores

    • Dependency updates and reorganization.

Two screens still rendered with the pre-redesign palette:

- Routes.jsx post-login data-loading screen used `bg-gray-900 text-teal-200`
  with a plain "Loading..." paragraph. Swapped for the system LoadingScreen
  component, matching the boot loader.
- ErrorBoundary.jsx ErrorFallback used `text-red-600` heading, `bg-gray-100`
  pre, and a `bg-blue-500` button — all raw Tailwind palette. Migrated to
  surface-0/surface-1, status-error heading, accent button, mono error pre
  with rule-1 hairline.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented May 3, 2026

Copy link
Copy Markdown

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

The pull request adds environment variable support with .env file loading to the backend, reorganizes the zustand dependency to the renderer package, and enhances the frontend UI with a LoadingScreen component and improved error boundary styling.

Changes

Environment Variable & .env File Loading

Layer / File(s) Summary
Dependency Addition
go.mod
Adds github.com/joho/godotenv v1.5.1 as an indirect dependency.
Startup Integration
internal/cmd/start.go
Loads .env file at application startup using godotenv.Load(), ignoring missing file errors and logging other errors as warnings.
Configuration Service
internal/services/config/configuration_service.go
NeedsEVEConfiguration and GetEVECredentials now prioritize environment variables (EVE_CLIENT_ID, EVE_CLIENT_SECRET, EVE_CALLBACK_URL) before falling back to stored config; callback URL defaults to http://localhost:42423/callback.

Frontend UI & Dependency Updates

Layer / File(s) Summary
Dependency Reorganization
package.json, renderer/package.json
Moves zustand dependency from root package to renderer package, updating to version ^5.0.7.
UI Components
renderer/src/Routes.jsx
Imports and renders LoadingScreen component during authentication and data loading states, replacing inline loading markup.
UI Styling
renderer/src/components/common/ErrorBoundary.jsx
Updates ErrorFallback component styling: container uses bg-surface-0 with padding, error heading switches to text-h2 text-status-error, message uses bg-surface-1 with constrained width and text wrapping, and retry button uses accent color scheme with reduced height.
Development Configuration
.claude/settings.local.json
Adds Bash(npm uninstall *) permission to the local tool settings allow-list.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Poem

🐰 A rabbit hops through .env fields so green,
Where secrets hide in dots unseen,
The frontend blooms with zustand care,
And loading screens float through the air! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: replacing old-theme UI components (loading screen and error surface) with new theme styling, which aligns with the primary modifications in Routes.jsx and ErrorBoundary.jsx.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/post-login-loading-teal
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/post-login-loading-teal

Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@guarzo
guarzo merged commit b086add into main May 3, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant