Add broot package#194
Conversation
broot v1.56.2 — interactive tree-style file browser/launcher. Captures bash/fish/zsh shell completions as explicit per-shell outputs (the zsh file is named `_broot`, which a single `broot*` glob misses). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Jake King seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
📝 WalkthroughWalkthroughThis pull request introduces a new package build specification for ChangesBroot package build specification
🎯 2 (Simple) | ⏱️ ~8 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/broot/build.sh`:
- Line 8: build.sh currently runs cargo build --release in the current directory
and ignores the MINIMAL_ARG_VERSION variable; change the script to cd into the
extracted source directory (use the expected directory name that includes
$MINIMAL_ARG_VERSION) before invoking cargo so the build uses the correct
versioned source, i.e., ensure build.sh references $MINIMAL_ARG_VERSION and
performs a cd into that source directory prior to running cargo build --release.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e5eeb0be-2523-46cb-99b2-f6540abf5537
📒 Files selected for processing (2)
packages/broot/build.nclpackages/broot/build.sh
| export LD=gcc | ||
| export RUSTFLAGS="-C linker=gcc --remap-path-prefix=$(pwd)=/builddir --remap-path-prefix=$HOME/.cargo=/cargo" | ||
|
|
||
| cargo build --release |
There was a problem hiding this comment.
Use the forwarded version arg and source-directory navigation in the build step.
The script currently ignores MINIMAL_ARG_VERSION and builds from the current directory directly; this violates the repository’s build script convention and weakens recipe/script contract clarity.
Proposed fix
+version="${MINIMAL_ARG_VERSION:?MINIMAL_ARG_VERSION is required}"
+src_dir="broot-${version}"
+if [[ -d "$src_dir" ]]; then
+ cd "$src_dir"
+fi
+
cargo build --releaseAs per coding guidelines, "Use 'cd' to navigate to the extracted source directory and reference the version variable via '$MINIMAL_ARG_VERSION' environment variable in build.sh".
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| cargo build --release | |
| version="${MINIMAL_ARG_VERSION:?MINIMAL_ARG_VERSION is required}" | |
| src_dir="broot-${version}" | |
| if [[ -d "$src_dir" ]]; then | |
| cd "$src_dir" | |
| fi | |
| cargo build --release |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/broot/build.sh` at line 8, build.sh currently runs cargo build
--release in the current directory and ignores the MINIMAL_ARG_VERSION variable;
change the script to cd into the extracted source directory (use the expected
directory name that includes $MINIMAL_ARG_VERSION) before invoking cargo so the
build uses the correct versioned source, i.e., ensure build.sh references
$MINIMAL_ARG_VERSION and performs a cd into that source directory prior to
running cargo build --release.
broot v1.56.2 — interactive tree-style file browser/launcher.
Fresh branch off current
main, replacing #160 (which was 26 commits behind). Carries one fix over that PR: shell completions are now declared as explicit per-shell outputs because the zsh completion file is named_broot, which the previous singleusr/share/**/broot*glob silently dropped.🤖 Generated with Claude Code
Summary by CodeRabbit