Add broot package#160
Conversation
broot v1.56.2 — interactive tree-style file browser/launcher. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a Nickel BuildSpec for broot v1.56.2 plus a Bash build script that builds the Rust release, installs the broot binary, and installs shell completions. Changesbroot Package Build Specification
Sequence Diagram(s)sequenceDiagram
participant Upstream
participant BuildSpec
participant Script
participant Cargo
participant Output
Upstream->>BuildSpec: provide source tarball
BuildSpec->>Script: invoke ./build.sh (version)
Script->>Cargo: cargo build --release
Cargo->>Script: produce binary + completions
Script->>Output: install binary and completions into $OUTPUT_DIR
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/broot/build.ncl`:
- Around line 39-42: The completions output declaration (outputs -> completions)
currently uses glob "usr/share/**/broot*" which misses the zsh file named
"_broot"; update the completions OutputData glob to explicitly include the zsh
artifact (e.g., add a pattern matching "_broot" such as "usr/share/**/_broot" or
expand the glob to include both "broot*" and "_broot") so the zsh completion
file produced by build.sh is captured by the completions output.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 5583bce0-26fc-4aa9-b5cb-e91eab544e98
📒 Files selected for processing (2)
packages/broot/build.nclpackages/broot/build.sh
| outputs = { | ||
| broot = { glob = "usr/bin/broot" } | OutputBin, | ||
| completions = { glob = "usr/share/**/broot*" } | OutputData, | ||
| }, |
There was a problem hiding this comment.
Declared completion output misses zsh _broot artifact.
Line 41 uses usr/share/**/broot*, but the zsh file installed by build.sh is _broot (underscore prefix), so it won’t be captured by this output declaration.
Proposed fix
outputs = {
broot = { glob = "usr/bin/broot" } | OutputBin,
completions = { glob = "usr/share/**/broot*" } | OutputData,
+ zsh_completion = { glob = "usr/share/zsh/site-functions/_broot" } | OutputData,
},As per coding guidelines: "Explicitly declare all outputs using OutputBin, OutputLib, or OutputData with glob patterns matching what build.sh installs".
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| outputs = { | |
| broot = { glob = "usr/bin/broot" } | OutputBin, | |
| completions = { glob = "usr/share/**/broot*" } | OutputData, | |
| }, | |
| outputs = { | |
| broot = { glob = "usr/bin/broot" } | OutputBin, | |
| completions = { glob = "usr/share/**/broot*" } | OutputData, | |
| zsh_completion = { glob = "usr/share/zsh/site-functions/_broot" } | OutputData, | |
| }, |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/broot/build.ncl` around lines 39 - 42, The completions output
declaration (outputs -> completions) currently uses glob "usr/share/**/broot*"
which misses the zsh file named "_broot"; update the completions OutputData glob
to explicitly include the zsh artifact (e.g., add a pattern matching "_broot"
such as "usr/share/**/_broot" or expand the glob to include both "broot*" and
"_broot") so the zsh completion file produced by build.sh is captured by the
completions output.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Superseded by #194 — fresh branch off current main, plus a fix to capture the zsh |
broot v1.56.2 — interactive tree-style file browser/launcher.
Summary by CodeRabbit