internal/config: make storage file paths overwritable via env vars#24177
Merged
rissson merged 1 commit intoJul 20, 2026
Conversation
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
BeryJu
approved these changes
Jul 18, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24177 +/- ##
==========================================
+ Coverage 93.47% 94.07% +0.59%
==========================================
Files 1059 1051 -8
Lines 63370 62946 -424
Branches 424 0 -424
==========================================
- Hits 59235 59214 -21
+ Misses 4135 3732 -403
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
dominic-r
approved these changes
Jul 18, 2026
Now *__FILE__PATH environemnt variables have an effect and can overwrite values from default.yml. Without this change uploaded files can not be accessed if the folder is different from the default /data because the GoLang part assumes a /data prefix and e.g. ignores AUTHENTIK_STORAGE__FILE__PATH.
alexeyabel
force-pushed
the
fix/make-storage-file-paths-overwritable-via-env-vars
branch
from
July 19, 2026 08:30
d9549fb to
6365c59
Compare
Contributor
Author
|
@BeryJu I don't understand all these workflows and approval processes and thus how to proceed. Am I supposed to merge this myself or will any of the maintainers do it? |
Member
|
thank you for your contribution! |
|
🍒 Cherry-pick to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now *__FILE__PATH environemnt variables have an effect and can overwrite values from default.yml. Without this change uploaded files can not be accessed if the folder is different from the default /data because the GoLang part assumes a /data prefix and e.g. ignores AUTHENTIK_STORAGE__FILE__PATH.
How was this tested?
I have not tested this. I am on NixOS and
make alldoes not work out-of-the-box due to dynamic linking. I presume that this minor change will not break anything.Linked issues
I have not created an issue, since I already (hopefully) have the solution.
P.S. AFAICS your package list does not include Go modules. Therefore, I was not able to chose a fitting prefix and came up with
config:. Feel free to change if you need. I just want this to be fixed.