fix: logging when proxyless method fails to start#36
Merged
Conversation
Currently if any of the methods fail to start it won't initialize kindling correctly
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts Kindling initialization so that a failure to start the proxyless (smart dialer) path doesn’t necessarily prevent Kindling from being created when other transports are available.
Changes:
- Log a warning (instead of returning an error) when deferred proxyless initialization fails.
- Minor formatting alignment in
http.Transportliterals.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Address PR review: previously NewKindling always swallowed deferred option errors (WithProxyless smart-dialer construction), so it could return success with zero transports and surface a confusing "no eligible transports" error at request time. Now we log each deferred failure as a warning but return an error if no transports are left. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Cover the two branches of the new NewKindling logic: a failed proxyless probe degrades to surviving transports, and a failed probe with no other transport surfaces an error at construction time. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
myleshorton
approved these changes
May 28, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if any deferred option (notably
WithProxyless's smart-dialer construction) failed to initialize,NewKindlingwould return an error and refuse to start — even when other transports were configured and working.This changes
NewKindlingto:errors.Join), so callers get a clear init-time failure instead of a confusing "no eligible transports for request" error later at request time.The
NewKindlingdoc comment is updated to describe this behavior.