deps: bump radiance to 24a73ef (brings kindling #3554 fix)#8824
Closed
myleshorton wants to merge 1 commit into
Closed
deps: bump radiance to 24a73ef (brings kindling #3554 fix)#8824myleshorton wants to merge 1 commit into
myleshorton wants to merge 1 commit into
Conversation
Bumps radiance 568c5ece→24a73ef (radiance#496), which transitively upgrades kindling a9712f95→21f8b144afab (kindling#36) and lantern-box v0.0.82→v0.0.84. The kindling bump is the fix for getlantern/engineering#3554: NewKindling now logs-and-degrades when a deferred transport (the smart dialer via WithProxyless) fails to initialize — fatal only when no transports remain — instead of collapsing the entire client to a non-circumventing default transport. Previously a smart-dialer "no fallback was specified" error took down domainfront + AMP + dnstt too, breaking config fetch in censored networks (Freshdesk #175766, RU). Also rides along ~a week of radiance main (config fetch coalescing #491, IPv6 ULA TUN #493, lantern-box bump #495, *net.TCPConn return #496, throughput allocations #498). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the radiance dependency to pick up the transitive kindling fix for degraded smart-dialer initialization, preserving other circumvention transports when one deferred transport fails.
Changes:
- Bumps
github.com/getlantern/radianceto24a73ef85d80. - Updates transitive dependencies:
kindling,lantern-box, andlantern-water. - Refreshes corresponding
go.sumchecksums.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
go.mod |
Updates the direct radiance requirement and related indirect dependency versions. |
go.sum |
Updates module checksums for the bumped dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Closing in favor or #8825 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps radiance
568c5ece→24a73ef85d80(radiance#496), which transitively upgrades:a9712f95→21f8b144afab(kindling#36) — the fix for getlantern/engineering#3554v0.0.82→v0.0.84958775d51395Why (the #3554 fix)
In censored networks the Outline smart dialer fails with
"no fallback was specified"(nofallback:in the smart config + all DNS/TLS strategies blocked). Previously that collapsed the entire kindling client to a non-circumventinghttp.DefaultTransportclone — dropping domainfront + AMP + dnstt too — which broke config fetch (Freshdesk #175766, RU/Beeline tester on 9.1.11-beta).kindling#36 makes
NewKindlinglog-and-degrade on a deferred-transport init failure, fatal only when no transports remain. So a smart-dialer failure now keeps domainfront/AMP/dnstt racing instead of giving up circumvention entirely.Scope note
This is the full radiance main bump (2026-05-21 → 2026-05-29), so it also rides along recent radiance work: config-fetch coalescing (#491), IPv6 ULA TUN (#493), lantern-box bump (#495),
*net.TCPConnreturn (#496), per-tick throughput allocations (#498). Reviewers should sanity-check those land cleanly together.Test plan
build-androidetc.) compiles against the bumped deps.Refs: getlantern/engineering#3554, kindling#36, radiance#496, Freshdesk #175766.