Skip to content

fix(e2e): grant geolocation to multiplayer browser contexts #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gelbh merged 2 commits into from
Jul 13, 2026
+10 −3
Merged

fix(e2e): grant geolocation to multiplayer browser contexts #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02f025b
fix(e2e): grant geolocation to multiplayer browser contexts
gelbh Jul 13, 2026
9452ff3
fix(e2e): drop readonly permissions tuple for Playwright typing
gelbh Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions e2e/fixtures/map.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
import { type Page, expect } from "@playwright/test";
import { clickViaEvaluate } from "./dom";

/** Matches Playwright `use.geolocation` in playwright.config.ts */
export const E2E_GEOLOCATION = { latitude: 53.35, longitude: -6.26 };

export const LOCAL_GAME_AREA = {
type: "Polygon" as const,
coordinates: [
Expand Down
10 changes: 7 additions & 3 deletions e2e/fixtures/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { type Browser, type Page, expect } from "@playwright/test";
import { LOCAL_GAME_AREA } from "./map";
import { E2E_GEOLOCATION, LOCAL_GAME_AREA } from "./map";
import { dismissMapOnboarding, prepareE2EPage } from "./page-init";
import type { BlockExternalAssetsOptions } from "./network";

Expand Down Expand Up @@ -172,8 +172,12 @@ export async function createMultiplayerContexts(
browser: Browser,
network: BlockExternalAssetsOptions = {},
) {
const hostContext = await browser.newContext();
const guestContext = await browser.newContext();
const contextOptions = {
geolocation: E2E_GEOLOCATION,
permissions: ["geolocation"],
};
const hostContext = await browser.newContext(contextOptions);
const guestContext = await browser.newContext(contextOptions);
Comment thread
coderabbitai[bot] marked this conversation as resolved.
const hostPage = await hostContext.newPage();
const guestPage = await guestContext.newPage();

Expand Down
Loading