Skip to content

fix(e2e): grant geolocation to multiplayer browser contexts#52

Merged
gelbh merged 2 commits into
mainfrom
fix/e2e-multiplayer-geolocation
Jul 13, 2026
Merged

fix(e2e): grant geolocation to multiplayer browser contexts#52
gelbh merged 2 commits into
mainfrom
fix/e2e-multiplayer-geolocation

Conversation

@gelbh

@gelbh gelbh commented Jul 13, 2026

Copy link
Copy Markdown
Owner

Summary

  • Pass Playwright geolocation + permissions into createMultiplayerContexts so host/guest pages can use "Use my location" in tentacle wizard
  • Fixes e2e-full failure: multiplayer.spec.ts tentacle question test (Next stayed disabled for 60s)

Test plan

  • CI e2e-full on this PR

Summary by CodeRabbit

  • Tests
    • Improved end-to-end multiplayer test reliability by using consistent geolocation values.
    • Added coverage for scenarios that require browser geolocation permissions.
    • Ensured host and guest test sessions behave consistently when location-aware features are exercised.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 5fe2e862-b638-4545-891c-1c1ae4ccd81c

📥 Commits

Reviewing files that changed from the base of the PR and between 02f025b and 9452ff3.

📒 Files selected for processing (1)
  • e2e/fixtures/session.ts

Walkthrough

E2E fixtures now define shared geolocation coordinates and apply them, with permission enabled, to both host and guest multiplayer Playwright contexts.

Changes

E2E geolocation

Layer / File(s) Summary
Configure multiplayer context geolocation
e2e/fixtures/map.ts, e2e/fixtures/session.ts
Exports fixed latitude and longitude values, imports them into the session fixture, and applies them with granted geolocation permission to host and guest browser contexts.

Estimated code review effort: 1 (Trivial) | ~5 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/e2e-multiplayer-geolocation

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@e2e/fixtures/session.ts`:
- Around line 175-180: Remove the `as const` assertion from the `permissions`
property in the `contextOptions` object used by the host and guest
`browser.newContext` calls, leaving it inferred as a mutable string array while
preserving the existing permission value.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 59df320e-6521-4bbc-ba01-7aef293579d3

📥 Commits

Reviewing files that changed from the base of the PR and between bbd62dd and 02f025b.

📒 Files selected for processing (2)
  • e2e/fixtures/map.ts
  • e2e/fixtures/session.ts

Comment thread e2e/fixtures/session.ts
@gelbh gelbh merged commit b6fbb20 into main Jul 13, 2026
7 checks passed
@gelbh gelbh deleted the fix/e2e-multiplayer-geolocation branch July 13, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant